Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Expire `cn` cookie at end of session (#13659) 

This cookie is used to transmit notification read state to the server. It is always cleared by the server on the next page load, so there is no need for the expiry to be so long. This commit updates it to expire at the end of the session (the default), and replaces raw `document.cookie` usage with our `cookie` library.
This commit is contained in:
David Taylor 2021-07-07 11:44:26 +01:00 committed by GitHub
parent 573a71fdd9
commit 2a1abe9ff0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/app/widgets/default-notification-item.js
View File

@ -14,6 +14,7 @@ import { h } from "virtual-dom";
import { iconNode } from "discourse-common/lib/icon-library";
import { isEmpty } from "@ember/utils";
import { wantsNewWindow } from "discourse/lib/intercept-click";
import cookie from "discourse/lib/cookie";
export const DefaultNotificationItem = createWidget(
"default-notification-item",
@ -147,11 +148,8 @@ export const DefaultNotificationItem = createWidget(
this.attrs.set("read", true);
const id = this.attrs.id;
setTransientHeader("Discourse-Clear-Notifications", id);
if (document && document.cookie) {
document.cookie = `cn=${id}; path=${getURL(
"/"
)}; expires=Fri, 31 Dec 9999 23:59:59 GMT`;
}
cookie("cn", id, { path: getURL("/") });
if (wantsNewWindow(e)) {
return;
}