Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: increment wait to prevent a specific flakey spec (#19599) 

I could repro the same failure by doing: `page.driver.browser.network_conditions = { offline: false, latency: 3000, throughput: 0 }`

Wait shouldn't be needed as we wait for selector, but I couldn't find a better solution on this case for now.
This commit is contained in:
Joffrey JAFFEUX 2022-12-23 01:34:25 +01:00 committed by GitHub
parent 86cafc7237
commit 2c295f76fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/chat/spec/system/channel_members_page_spec.rb
View File

@ -50,7 +50,7 @@ RSpec.describe "Channel - Info - Members page", type: :system, js: true do
scroll_to(find(".channel-members-view__list-item:nth-child(50)"))
expect(page).to have_selector(".channel-members-view__list-item", count: 100)
expect(page).to have_selector(".channel-members-view__list-item", count: 100, wait: 5)
scroll_to(find(".channel-members-view__list-item:nth-child(100)"))