FIX: Regression with Categories nav item (#17885)
This commit is contained in:
parent
4b70594173
commit
2c5ab47204
|
@ -10,6 +10,6 @@ export default Controller.extend(FilterModeMixin, {
|
|||
|
||||
@discourseComputed("router.currentRoute.queryParams.f")
|
||||
skipCategoriesNavItem(filterParamValue) {
|
||||
return !filterParamValue || filterParamValue !== TRACKED_QUERY_PARAM_VALUE;
|
||||
return filterParamValue === TRACKED_QUERY_PARAM_VALUE;
|
||||
},
|
||||
});
|
||||
|
|
|
@ -262,7 +262,7 @@ NavItem.reopenClass({
|
|||
}
|
||||
|
||||
if (
|
||||
(category || !args.skipCategoriesNavItem) &&
|
||||
(category || args.skipCategoriesNavItem) &&
|
||||
i.name.startsWith("categor")
|
||||
) {
|
||||
return false;
|
||||
|
|
|
@ -69,6 +69,13 @@ acceptance("Topic Discovery Tracked", function (needs) {
|
|||
"the categories nav item is displayed when tracked filter is not present"
|
||||
);
|
||||
|
||||
await visit("/categories");
|
||||
|
||||
assert.ok(
|
||||
exists("#navigation-bar li.categories"),
|
||||
"the categories nav item is displayed on categories route when tracked filter is not present"
|
||||
);
|
||||
|
||||
await visit("/?f=tracked");
|
||||
|
||||
assert.ok(
|
||||
|
|
Loading…
Reference in New Issue