From 2d46824a87f2104b307abd76dbb2ec2b0f2df4a0 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Thu, 23 Mar 2023 13:09:45 +0800 Subject: [PATCH] DEV: Switch to data attributes to represent sidebar section name (#20771) Data attributes are less restrictive than the class attribute. --- .../app/components/sidebar/section.hbs | 6 +- ...debar-anonymous-categories-section-test.js | 8 +- ...idebar-anonymous-community-section-test.js | 12 +- .../sidebar-anonymous-tags-section-test.js | 14 +- .../acceptance/sidebar-plugin-api-test.js | 38 +-- .../sidebar-user-categories-section-test.js | 70 +++-- .../sidebar-user-community-section-test.js | 274 ++++++++++++------ .../sidebar-user-messages-section-test.js | 112 ++++--- .../sidebar-user-tags-section-test.js | 63 ++-- .../tests/acceptance/sidebar-user-test.js | 4 +- .../user-preferences-sidebar-test.js | 44 +-- .../spec/system/list_channels/sidebar_spec.rb | 20 +- .../system/page_objects/sidebar/sidebar.rb | 14 +- spec/system/custom_sidebar_sections_spec.rb | 13 +- .../system/page_objects/components/sidebar.rb | 7 +- 15 files changed, 455 insertions(+), 244 deletions(-) diff --git a/app/assets/javascripts/discourse/app/components/sidebar/section.hbs b/app/assets/javascripts/discourse/app/components/sidebar/section.hbs index a521e36004a..88e5a6df42b 100644 --- a/app/assets/javascripts/discourse/app/components/sidebar/section.hbs +++ b/app/assets/javascripts/discourse/app/components/sidebar/section.hbs @@ -1,9 +1,7 @@ {{#if this.displaySection}}