Merge pull request #1745 from ok-harry/master

FIX: Title text should be correctly escaped since we are generating a raw html
2013-12-23 05:48:42 -08:00 · 2013-12-23 05:48:42 -08:00 · 30565dcd8f
parent 34cbea64d1 dfc95d0f6f
commit 30565dcd8f
1 changed files with 1 additions and 1 deletions
--- a/app/assets/javascripts/discourse/helpers/application_helpers.js
+++ b/app/assets/javascripts/discourse/helpers/application_helpers.js
@ -289,7 +289,7 @@ Handlebars.registerHelper('number', function(property, options) {
  var result = "<span class='" + classNames + "'";

  if (n !== title) {
-    result += " title='" + title + "'";
+    result += " title='" + Handlebars.Utils.escapeExpression(title) + "'";
  }
  result += ">" + n + "</span>";