Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

REFACTOR: category hashtags controller specs to requests (#5936)

This commit is contained in:
OsamaSayegh 2018-06-07 08:09:23 +03:00 committed by Guo Xiang Tan
parent 9975f9751e
commit 30be1b0d2b
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
spec/controllers/category_hashtags_controller_spec.rb → spec/requests/category_hashtags_controller_spec.rb
View File

@ -4,14 +4,15 @@ describe CategoryHashtagsController do
describe "check" do describe "check" do
describe "logged in" do describe "logged in" do
before do before do
log_in(:user) sign_in(Fabricate(:user))
end end
it 'only returns the categories that are valid' do it 'only returns the categories that are valid' do
category = Fabricate(:category) category = Fabricate(:category)
get :check, params: { category_slugs: [category.slug, 'none'] }, format: :json get "/category_hashtags/check.json", params: { category_slugs: [category.slug, 'none'] }
expect(response.status).to eq(200)
expect(JSON.parse(response.body)).to eq( expect(JSON.parse(response.body)).to eq(
"valid" => [{ "slug" => category.hashtag_slug, "url" => category.url_with_id }] "valid" => [{ "slug" => category.hashtag_slug, "url" => category.url_with_id }]
) )
@ -21,21 +22,22 @@ describe CategoryHashtagsController do
group = Fabricate(:group) group = Fabricate(:group)
private_category = Fabricate(:private_category, group: group) private_category = Fabricate(:private_category, group: group)
get :check, params: { category_slugs: [private_category.slug] }, format: :json get "/category_hashtags/check.json", params: { category_slugs: [private_category.slug] }
expect(response.status).to eq(200)
expect(JSON.parse(response.body)).to eq("valid" => []) expect(JSON.parse(response.body)).to eq("valid" => [])
end end
it 'returns restricted categories for an admin' do it 'returns restricted categories for an admin' do
admin = log_in(:admin) admin = sign_in(Fabricate(:admin))
group = Fabricate(:group) group = Fabricate(:group)
group.add(admin) group.add(admin)
private_category = Fabricate(:private_category, group: group) private_category = Fabricate(:private_category, group: group)
get :check, get "/category_hashtags/check.json",
params: { category_slugs: [private_category.slug] }, params: { category_slugs: [private_category.slug] }
format: :json
expect(response.status).to eq(200)
expect(JSON.parse(response.body)).to eq( expect(JSON.parse(response.body)).to eq(
"valid" => [{ "slug" => private_category.hashtag_slug, "url" => private_category.url_with_id }] "valid" => [{ "slug" => private_category.hashtag_slug, "url" => private_category.url_with_id }]
) )
@ -44,7 +46,7 @@ describe CategoryHashtagsController do
describe "not logged in" do describe "not logged in" do
it 'raises an exception' do it 'raises an exception' do
get :check, params: { category_slugs: [] }, format: :json get "/category_hashtags/check.json", params: { category_slugs: [] }
expect(response.status).to eq(403) expect(response.status).to eq(403)
end end
end end