Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Try fix bookmark flaky (#29069) 

I think the check for the bookmark icon is too optimistic,
so the DB might not be updated by the time we check. Using
try_until_success should fix this, we also don't have a
toast to check against via AJAX success, by design.
This commit is contained in:
Martin Brennan 2024-10-03 14:34:36 +10:00 committed by GitHub
parent ef00d6f633
commit 3108e3a6b6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
spec/system/bookmarks_spec.rb
View File

@ -33,7 +33,9 @@ describe "Bookmarking posts and topics", type: :system do
expect(bookmark_menu).to be_open
expect(page).to have_content(I18n.t("js.bookmarks.bookmarked_success"))
expect(topic_page).to have_post_bookmarked(post, with_reminder: false)
expect(Bookmark.find_by(bookmarkable: post, user: current_user)).to be_truthy
try_until_success(frequency: 0.5) do
expect(Bookmark.find_by(bookmarkable: post, user: current_user)).to be_truthy
end
end
it "updates the created bookmark with a selected reminder option from the bookmark menu" do
@ -46,7 +48,9 @@ describe "Bookmarking posts and topics", type: :system do
expect(topic_page).to have_post_bookmarked(post, with_reminder: true)
expect(page).to have_no_css(".bookmark-menu-content.-expanded")
expect(Bookmark.find_by(bookmarkable: post, user: current_user).reminder_at).not_to be_blank
try_until_success(frequency: 0.5) do
expect(Bookmark.find_by(bookmarkable: post, user: current_user).reminder_at).not_to be_blank
end
end
it "can set a reminder from the bookmark modal using the custom bookmark menu option" do
@ -54,7 +58,9 @@ describe "Bookmarking posts and topics", type: :system do
bookmark_menu.click_menu_option("custom")
bookmark_modal.select_preset_reminder(:tomorrow)
expect(topic_page).to have_post_bookmarked(post, with_reminder: true)
expect(Bookmark.find_by(bookmarkable: post, user: current_user).reminder_at).not_to be_blank
try_until_success(frequency: 0.5) do
expect(Bookmark.find_by(bookmarkable: post, user: current_user).reminder_at).not_to be_blank
end
end
it "allows choosing a different auto_delete_preference to the user preference and remembers it when reopening the modal" do