Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: can't drag selected text

This commit is contained in:
Régis Hanol 2013-06-28 23:05:45 +02:00
parent a352b70bfc
commit 31bf1c4b2e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/views/quote_button_view.js
View File

@ -46,8 +46,10 @@ Discourse.QuoteButtonView = Discourse.View.extend({
.on("mousedown.quote-button", function(e) { .on("mousedown.quote-button", function(e) {
view.set('isMouseDown', true); view.set('isMouseDown', true);
if ($(e.target).hasClass('quote-button') || $(e.target).hasClass('create')) return; if ($(e.target).hasClass('quote-button') || $(e.target).hasClass('create')) return;
// deselects only when the user left-click // do *not* deselect when quoting has been disabled by the user
// this also allow anyone to `extend` their selection using a shift+click if (!Discourse.User.current('enable_quoting')) return;
// deselects only when the user left click
// (allows anyone to `extend` their selection using shift+click)
if (e.which === 1 && !e.shiftKey) controller.deselectText(); if (e.which === 1 && !e.shiftKey) controller.deselectText();
}) })
.on('mouseup.quote-button', function(e) { .on('mouseup.quote-button', function(e) {
@ -69,7 +71,7 @@ Discourse.QuoteButtonView = Discourse.View.extend({
**/ **/
selectText: function(target, controller) { selectText: function(target, controller) {
var $target = $(target); var $target = $(target);
// quoting as been disabled by the user // breaks if quoting has been disabled by the user
if (!Discourse.User.current('enable_quoting')) return; if (!Discourse.User.current('enable_quoting')) return;
// retrieve the post id from the DOM // retrieve the post id from the DOM
var postId = $target.closest('.boxed').data('post-id'); var postId = $target.closest('.boxed').data('post-id');