Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: `Discourse.keep_readonly_mode` spins a new thread each time it is called.

This commit is contained in:
Guo Xiang Tan 2018-06-19 10:15:29 +08:00
parent 6e97242bb9
commit 34e4c8f573
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/discourse.rb
View File

@ -294,7 +294,12 @@ module Discourse
def self.keep_readonly_mode(key) def self.keep_readonly_mode(key)
# extend the expiry by 1 minute every 30 seconds # extend the expiry by 1 minute every 30 seconds
unless Rails.env.test? unless Rails.env.test?
Thread.new do @threads ||= {}
active_thread = @threads[key]
unless active_thread&.alive?
@threads[key] = Thread.new do
while readonly_mode?(key) while readonly_mode?(key)
$redis.expire(key, READONLY_MODE_KEY_TTL) $redis.expire(key, READONLY_MODE_KEY_TTL)
sleep 30.seconds sleep 30.seconds
@ -302,6 +307,7 @@ module Discourse
end end
end end
end end
end
def self.disable_readonly_mode(key = READONLY_MODE_KEY) def self.disable_readonly_mode(key = READONLY_MODE_KEY)
$redis.del(key) $redis.del(key)