Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove flaky test from TopcisFilter (#21543) 

TopicsFilter is meant to generate a query scope from a given string so
we don't really need to ensure any ordering outside of the supported
order filters.
This commit is contained in:
Alan Guo Xiang Tan 2023-05-15 12:18:58 +09:00 committed by GitHub
parent 06f9c0149c
commit 366c676156
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
spec/lib/topics_filter_spec.rb
View File

@ -1334,20 +1334,6 @@ RSpec.describe TopicsFilter do
fab!(:topic3) { Fabricate(:topic, category: category) }
include_examples "ordering topics filters", "category", "category name"
describe "when query string is `order:category` and there are multiple topics in a category" do
fab!(:topic4) { Fabricate(:topic, category: category) }
fab!(:topic5) { Fabricate(:topic, category: category2) }
it "should return topics ordered by category name in descending order and then topic id in ascending order" do
expect(
TopicsFilter
.new(guardian: Guardian.new)
.filter_from_query_string("order:category")
.pluck(:id),
).to eq([topic2.id, [topic.id, topic5.id].sort, [topic3.id, topic4.id].sort].flatten)
end
end
end
describe "composing multiple order filters" do