Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Don't depend on assets path to determine layout that is rendered (#24562) 

Why this change?

In the `invites_controller_spec.rb` file, we had several tests that were
checking for assets path in the response's body to determine which
layout has been rendered. However, those test fails if `bin/ember-cli
--build` has been run locally.

What does this change do?

Instead of checking for asset paths to determine the layout that has
been rendered, this change relies on the fact that the `no_ember` layout
has a `no-ember` class on the `body` element. This is more deterministic
as compared to relying on the different asset paths that are rendered in
the response.
This commit is contained in:
Alan Guo Xiang Tan 2023-11-27 14:04:13 +08:00 committed by GitHub
parent e6ebeac640
commit 36a9d4df3a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
spec/requests/invites_controller_spec.rb
View File

@ -47,7 +47,7 @@ RSpec.describe InvitesController do
it "shows unobfuscated email" do
get "/invites/#{invite.invite_key}"
expect(response.status).to eq(200)
expect(response.body).to have_tag(:script, with: { src: "/assets/discourse.js" })
expect(response.body).to_not have_tag(:body, with: { class: "no-ember" })
expect(response.body).to include(invite.email)
expect(response.body).not_to include("i*****g@a***********e.ooo")
end
@ -94,7 +94,7 @@ RSpec.describe InvitesController do
get "/invites/#{invite.invite_key}"
expect(response.status).to eq(200)
expect(response.body).to have_tag(:script, with: { src: "/assets/discourse.js" })
expect(response.body).to_not have_tag(:body, with: { class: "no-ember" })
expect(response.body).not_to include(
I18n.t(
"invite.not_found_template",
@ -119,7 +119,7 @@ RSpec.describe InvitesController do
get "/invites/#{invite.invite_key}"
expect(response.status).to eq(200)
expect(response.body).to have_tag(:script, with: { src: "/assets/discourse.js" })
expect(response.body).to_not have_tag(:body, with: { class: "no-ember" })
expect(response.body).not_to include(
I18n.t(
"invite.not_found_template",
@ -204,7 +204,8 @@ RSpec.describe InvitesController do
it "fails if invite does not exist" do
get "/invites/missing"
expect(response.status).to eq(200)
expect(response.body).to_not have_tag(:script, with: { src: "/assets/application.js" })
expect(response.body).to have_tag(:body, with: { class: "no-ember" })
expect(response.body).to include(I18n.t("invite.not_found", base_url: Discourse.base_url))
end
@ -213,7 +214,8 @@ RSpec.describe InvitesController do
get "/invites/#{invite.invite_key}"
expect(response.status).to eq(200)
expect(response.body).to_not have_tag(:script, with: { src: "/assets/application.js" })
expect(response.body).to have_tag(:body, with: { class: "no-ember" })
expect(response.body).to include(I18n.t("invite.expired", base_url: Discourse.base_url))
end
@ -229,7 +231,8 @@ RSpec.describe InvitesController do
get "/invites/#{invite.invite_key}"
expect(response.status).to eq(200)
expect(response.body).to_not have_tag(:script, with: { src: "/assets/application.js" })
expect(response.body).to have_tag(:body, with: { class: "no-ember" })
expect(response.body).to include(
I18n.t(
"invite.not_found_template",
@ -242,7 +245,8 @@ RSpec.describe InvitesController do
get "/invites/#{invite.invite_key}"
expect(response.status).to eq(200)
expect(response.body).to_not have_tag(:script, with: { src: "/assets/application.js" })
expect(response.body).to have_tag(:body, with: { class: "no-ember" })
expect(response.body).to include(
I18n.t(
"invite.not_found_template_link",