From 3837eb45b87b01927a75dd2c5e01f48f935c9655 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Wed, 2 Feb 2022 10:56:03 -0500 Subject: [PATCH] FIX: Qunit tests were failing if your node was defaulting to IPV6 (#15773) This is now the default in newer node versions. The code that fails is a workaround for another error :'( This also upgrades `chrome-launcher` which helpers with debugging. --- package.json | 2 +- test/run-qunit.js | 4 ++-- yarn.lock | 39 ++++++++++++--------------------------- 3 files changed, 15 insertions(+), 30 deletions(-) diff --git a/package.json b/package.json index 59c67a341b9..ddb9c608515 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "@arkweid/lefthook": "^0.7.2", "@mixer/parallel-prettier": "^2.0.1", "browserify": "^17.0.0", - "chrome-launcher": "^0.12.0", + "chrome-launcher": "^0.14.2", "chrome-remote-interface": "^0.25", "lodash-cli": "https://github.com/lodash-archive/lodash-cli.git", "pretender": "^3.4.7", diff --git a/test/run-qunit.js b/test/run-qunit.js index 2ec905fc503..de5bd7f8aff 100644 --- a/test/run-qunit.js +++ b/test/run-qunit.js @@ -61,7 +61,7 @@ async function runAllTests() { // Workaround for intermittent CI error caused by // https://github.com/GoogleChrome/chrome-launcher/issues/145 try { - protocol = await CDP({ port: chrome.port }); + protocol = await CDP({ port: chrome.port, host: "127.0.0.1" }); } catch (e) { if (e.message === "No inspectable targets" && connectAttempts < 50) { connectAttempts++; @@ -279,7 +279,7 @@ function logQUnit() { console.log("Slowest tests"); console.log("----------------------------------------------"); let ary = Object.keys(durations).map((key) => ({ - key: key, + key, value: durations[key], })); ary.sort((p1, p2) => p2.value - p1.value); diff --git a/yarn.lock b/yarn.lock index b065bb7908f..c7471bdcc01 100644 --- a/yarn.lock +++ b/yarn.lock @@ -917,16 +917,15 @@ chownr@^1.1.1: resolved "https://registry.yarnpkg.com/chownr/-/chownr-1.1.4.tgz#6fc9d7b42d32a583596337666e7d08084da2cc6b" integrity sha512-jJ0bqzaylmJtVnNgzTeSOs8DPavpbYgEr/b0YL8/2GO3xJEhInFmhKMUnEJQjZumK7KXGFhUy89PrsJWlakBVg== -chrome-launcher@^0.12.0: - version "0.12.0" - resolved "https://registry.yarnpkg.com/chrome-launcher/-/chrome-launcher-0.12.0.tgz#08db81ef0f7b283c331df2c350e780c38bd0ce3a" - integrity sha512-rBUP4tvWToiileDi3UR0SbWKoUoDCYTRmVND2sdoBL1xANBgVz8V9h1yQluj3MEQaBJg0fRw7hW82uOPrJus7A== +chrome-launcher@^0.14.2: + version "0.14.2" + resolved "https://registry.yarnpkg.com/chrome-launcher/-/chrome-launcher-0.14.2.tgz#5cb334794b9e83fad7303c96c131a4ec9e9f83a6" + integrity sha512-Nk8DUCIfPR6p9WClPPFeP2ztpAdkT8xueoiDS03csea1uoJjm4w0p5Oy1hjykyjT1EQ0MMrEshLD3C8gHXyiZw== dependencies: "@types/node" "*" - is-wsl "^2.1.0" + escape-string-regexp "^4.0.0" + is-wsl "^2.2.0" lighthouse-logger "^1.0.0" - mkdirp "0.5.1" - rimraf "^2.6.1" chrome-remote-interface@^0.25: version "0.25.7" @@ -1480,6 +1479,11 @@ escape-string-regexp@^1.0.5: resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz#1b61c0562190a8dff6ae3bb2cf0200ca130b86d4" integrity sha1-G2HAViGQqN/2rjuyzwIAyhMLhtQ= +escape-string-regexp@^4.0.0: + version "4.0.0" + resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-4.0.0.tgz#14ba83a5d373e3d311e5afca29cf5bfad965bf34" + integrity sha512-TtpcNJ3XAzx3Gq8sWRzJaVajRs0uVxA2YAkdb1jm2YkPz4G6egUFAyA3n5vtEIZefPk5Wa4UXbKuS5fKkJWdgA== + eslint-config-discourse@^1.1.9: version "1.1.9" resolved "https://registry.yarnpkg.com/eslint-config-discourse/-/eslint-config-discourse-1.1.9.tgz#9a5ee6b3a4b986e5243f517e7945d1709c4e22df" @@ -2543,7 +2547,7 @@ is-windows@^1.0.1, is-windows@^1.0.2: resolved "https://registry.yarnpkg.com/is-windows/-/is-windows-1.0.2.tgz#d1850eb9791ecd18e6182ce12a30f396634bb19d" integrity sha512-eXK1UInq2bPmjyX6e3VHIzMLobc4J94i4AWn+Hpq3OU5KkrRC96OAcR3PRJ/pGu6m8TRnBHP9dkXQVsT/COVIA== -is-wsl@^2.1.0: +is-wsl@^2.2.0: version "2.2.0" resolved "https://registry.yarnpkg.com/is-wsl/-/is-wsl-2.2.0.tgz#74a4c76e77ca9fd3f932f290c17ea326cd157271" integrity sha512-fKzAra0rGJUUBwGBgNkHZuToZcn+TtXHpeCgmkMJMMYx1sQDYaCSyjJBSCa2nH1DGm7s3n1oBnohoVTBaN7Lww== @@ -2883,11 +2887,6 @@ minimatch@^3.0.2, minimatch@^3.0.4: dependencies: brace-expansion "^1.1.7" -minimist@0.0.8: - version "0.0.8" - resolved "https://registry.yarnpkg.com/minimist/-/minimist-0.0.8.tgz#857fcabfc3397d2625b8228262e86aa7a011b05d" - integrity sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0= - minimist@^1.1.0, minimist@^1.1.1, minimist@^1.2.0, minimist@^1.2.5: version "1.2.5" resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.5.tgz#67d66014b66a6a8aaa0c083c5fd58df4e4e97602" @@ -2906,13 +2905,6 @@ mkdirp-classic@^0.5.2: resolved "https://registry.yarnpkg.com/mkdirp-classic/-/mkdirp-classic-0.5.3.tgz#fa10c9115cc6d8865be221ba47ee9bed78601113" integrity sha512-gKLcREMhtuZRwRAfqP3RFW+TK4JqApVBtOIftVgjuABpAtpxhPGaDcfvbhNvD0B8iD1oUr/txX35NjcaY6Ns/A== -mkdirp@0.5.1: - version "0.5.1" - resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.5.1.tgz#30057438eac6cf7f8c4767f38648d6697d75c903" - integrity sha1-MAV0OOrGz3+MR2fzhkjWaX11yQM= - dependencies: - minimist "0.0.8" - mkdirp@^0.5.1: version "0.5.5" resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-0.5.5.tgz#d91cefd62d1436ca0f41620e251288d420099def" @@ -3647,13 +3639,6 @@ rimraf@3.0.2, rimraf@^3.0.0: dependencies: glob "^7.1.3" -rimraf@^2.6.1: - version "2.7.1" - resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.7.1.tgz#35797f13a7fdadc566142c29d4f07ccad483e3ec" - integrity sha512-uWjbaKIK3T1OSVptzX7Nl6PvQ3qAGtKEtVRjRuazjfL3Bx5eI409VZSqgND+4UNnmzLVdPj9FqFJNPqBZFve4w== - dependencies: - glob "^7.1.3" - ripemd160@^2.0.0, ripemd160@^2.0.1: version "2.0.2" resolved "https://registry.yarnpkg.com/ripemd160/-/ripemd160-2.0.2.tgz#a1c1a6f624751577ba5d07914cbc92850585890c"