FIX: If the error is 401 unauthorized or such, just do nothing

2017-05-25 15:42:05 -04:00 · 2017-05-25 15:42:05 -04:00 · 39e1948174
parent b584264d82
commit 39e1948174
1 changed files with 5 additions and 1 deletions
--- a/app/models/topic_embed.rb
+++ b/app/models/topic_embed.rb
@ -89,7 +89,11 @@ class TopicEmbed < ActiveRecord::Base
    embed_classname_whitelist = SiteSetting.embed_classname_whitelist if SiteSetting.embed_classname_whitelist.present?

    response = FetchResponse.new
-    html = open(URI.encode(url), allow_redirections: :safe).read
+    begin
+      html = open(URI.encode(url), allow_redirections: :safe).read
+    rescue OpenURI::HTTPError
+      return
+    end

    raw_doc = Nokogiri::HTML(html)
    auth_element = raw_doc.at('meta[@name="author"]')