Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Consider lazyYT divs as links when extracting

This commit is contained in:
Robin Ward 2016-09-22 16:50:05 -04:00
parent e0be2f482e
commit 3c12dd6549
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/pretty_text.rb
View File

@ -294,6 +294,11 @@ module PrettyText
links << DetectedLink.new(url, true) links << DetectedLink.new(url, true)
end end
# Extract Youtube links
doc.css("div[data-youtube-id]").each do |d|
links << DetectedLink.new("https://www.youtube.com/watch?v=#{d['data-youtube-id']}", false)
end
links links
end end

4
spec/components/pretty_text_spec.rb
View File

@ -204,6 +204,10 @@ HTML
expect(extract_urls("<aside class=\"quote\" data-topic=\"321\">aside</aside>")).to eq(["/t/topic/321"]) expect(extract_urls("<aside class=\"quote\" data-topic=\"321\">aside</aside>")).to eq(["/t/topic/321"])
end end
it "should lazyYT videos" do
expect(extract_urls("<div class=\"lazyYT\" data-youtube-id=\"yXEuEUQIP3Q\" data-youtube-title=\"Mister Rogers defending PBS to the US Senate\" data-width=\"480\" data-height=\"270\" data-parameters=\"feature=oembed&amp;wmode=opaque\"></div>")).to eq(["https://www.youtube.com/watch?v=yXEuEUQIP3Q"])
end
it "should extract links to posts" do it "should extract links to posts" do
expect(extract_urls("<aside class=\"quote\" data-topic=\"1234\" data-post=\"4567\">aside</aside>")).to eq(["/t/topic/1234/4567"]) expect(extract_urls("<aside class=\"quote\" data-topic=\"1234\" data-post=\"4567\">aside</aside>")).to eq(["/t/topic/1234/4567"])
end end