Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "FIX: Auth popup handling for Safari same-site cookie quirks" 

This reverts commit 310a8ac242.

It seems this breaks google authentication. My suspicion is opening
the URL twice invalidates the CSRF after the first access.
This commit is contained in:
Robin Ward 2019-09-06 15:46:48 -04:00
parent 52461abad9
commit 3e3f6b1b62
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/models/login-method.js.es6
View File

@ -53,7 +53,7 @@ const LoginMethod = Ember.Object.extend({
} }
LoginMethod.buildPostForm(authUrl).then(form => { LoginMethod.buildPostForm(authUrl).then(form => {
const windowState = window.open( const windowState = window.open(
authUrl, "about:blank",
"auth_popup", "auth_popup",
`menubar=no,status=no,height=${height},width=${width},left=${left},top=${top}` `menubar=no,status=no,height=${height},width=${width},left=${left},top=${top}`
); );