FIX: Do not set title attribute on header-topic-info widget (#9533)

This commit is contained in:
Mark VanLandingham 2020-04-23 12:44:20 -05:00 committed by GitHub
parent e35286eda2
commit 3e543dfa18
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 6 deletions

View File

@ -115,7 +115,7 @@ export default createWidget("header-topic-info", {
); );
} }
this.title = [h("h1.header-title", heading)]; this.headerElements = [h("h1.header-title", heading)];
const category = topic.get("category"); const category = topic.get("category");
if (loaded || category) { if (loaded || category) {
@ -133,7 +133,7 @@ export default createWidget("header-topic-info", {
} }
categories.push(this.attach("category-link", { category })); categories.push(this.attach("category-link", { category }));
this.title.push(h("div.categories-wrapper", categories)); this.headerElements.push(h("div.categories-wrapper", categories));
} }
let extra = []; let extra = [];
@ -203,11 +203,10 @@ export default createWidget("header-topic-info", {
} }
} }
if (extra.length) { if (extra.length) {
this.title.push(h("div.topic-header-extra", extra)); this.headerElements.push(h("div.topic-header-extra", extra));
} }
} }
this.contents = h("div.title-wrapper", this.headerElements);
this.contents = h("div.title-wrapper", this.title);
}, },
html() { html() {
@ -219,7 +218,7 @@ export default createWidget("header-topic-info", {
}, },
containerClassName() { containerClassName() {
return this.title.length > 1 ? "two-rows" : ""; return this.headerElements.length > 1 ? "two-rows" : "";
}, },
jumpToTopPost() { jumpToTopPost() {