Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

REVERT: "A11Y: topic list links should not be headings (#27700)" (#29520) 

This reverts commit 72a5389459.
This commit is contained in:
Kris 2024-10-31 12:42:55 -04:00 committed by GitHub
parent 210a295a87
commit 3fb3e3560e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/topic-list/topic-link.gjs
View File

@ -13,6 +13,8 @@ export default class TopicLink extends Component {
<a <a
href={{this.url}} href={{this.url}}
data-topic-id={{@topic.id}} data-topic-id={{@topic.id}}
role="heading"
aria-level="2"
class="title" class="title"
...attributes ...attributes
>{{htmlSafe @topic.fancyTitle}}</a> >{{htmlSafe @topic.fancyTitle}}</a>

2
app/assets/javascripts/discourse/app/helpers/topic-link.js
View File

@ -17,6 +17,8 @@ export default function topicLink(topic, args = {}) {
return htmlSafe( return htmlSafe(
`<a href='${url}' `<a href='${url}'
role='heading'
aria-level='2'
class='${classes.join(" ")}' class='${classes.join(" ")}'
data-topic-id='${topic.id}'>${title}</a>` data-topic-id='${topic.id}'>${title}</a>`
); );