From 3fd784b51378a496a356436310b1773c0e728661 Mon Sep 17 00:00:00 2001
From: Akshay <akshaymohite31@yahoo.com>
Date: Tue, 19 Aug 2014 18:10:23 +0530
Subject: [PATCH] removed useless assignments at some places

---
 app/models/discourse_single_sign_on.rb | 2 +-
 app/models/invite_redeemer.rb          | 2 +-
 app/models/plugin_store.rb             | 2 +-
 app/models/topic_embed.rb              | 2 +-
 app/models/user.rb                     | 1 -
 lib/cooked_post_processor.rb           | 2 +-
 6 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/app/models/discourse_single_sign_on.rb b/app/models/discourse_single_sign_on.rb
index 52eff1357f3..b75ebd4613a 100644
--- a/app/models/discourse_single_sign_on.rb
+++ b/app/models/discourse_single_sign_on.rb
@@ -92,7 +92,7 @@ class DiscourseSingleSignOn < SingleSignOn
         sso_record.last_payload = unsigned_payload
         sso_record.external_id = external_id
       else
-        sso_record = user.create_single_sign_on_record(last_payload: unsigned_payload,
+        user.create_single_sign_on_record(last_payload: unsigned_payload,
                                           external_id: external_id,
                                           external_username: username,
                                           external_email: email,
diff --git a/app/models/invite_redeemer.rb b/app/models/invite_redeemer.rb
index bda7870aa07..15c2cb6cc88 100644
--- a/app/models/invite_redeemer.rb
+++ b/app/models/invite_redeemer.rb
@@ -99,7 +99,7 @@ InviteRedeemer = Struct.new(:invite, :username, :name) do
   end
 
   def approve_account_if_needed
-    invited_user.approve(invite.invited_by_id, send_email=false)
+    invited_user.approve(invite.invited_by_id, false)
   end
 
   def notify_invitee
diff --git a/app/models/plugin_store.rb b/app/models/plugin_store.rb
index 5ef649e072e..ecf8d9c73e3 100644
--- a/app/models/plugin_store.rb
+++ b/app/models/plugin_store.rb
@@ -8,7 +8,7 @@ class PluginStore
 
   def self.set(plugin_name, key, value)
     hash = {plugin_name: plugin_name, key: key}
-    row = PluginStoreRow.find_by(hash) || row = PluginStoreRow.new(hash)
+    row = PluginStoreRow.find_by(hash) || PluginStoreRow.new(hash)
 
     row.type_name = determine_type(value)
     # nil are stored as nil
diff --git a/app/models/topic_embed.rb b/app/models/topic_embed.rb
index ffb1f6915df..1d284d80a44 100644
--- a/app/models/topic_embed.rb
+++ b/app/models/topic_embed.rb
@@ -151,7 +151,7 @@ class TopicEmbed < ActiveRecord::Base
   def self.expanded_for(post)
     Rails.cache.fetch("embed-topic:#{post.topic_id}", expires_in: 10.minutes) do
       url = TopicEmbed.where(topic_id: post.topic_id).pluck(:embed_url).first
-      title, body = TopicEmbed.find_remote(url)
+      _title, body = TopicEmbed.find_remote(url)
       body << TopicEmbed.imported_from_html(url)
       body
     end
diff --git a/app/models/user.rb b/app/models/user.rb
index b9ebf903417..1ec99c667a7 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -173,7 +173,6 @@ class User < ActiveRecord::Base
   end
 
   def change_username(new_username)
-    current_username = self.username
     self.username = new_username
     save
   end
diff --git a/lib/cooked_post_processor.rb b/lib/cooked_post_processor.rb
index f8bed1bc38d..208aa5d3ab0 100644
--- a/lib/cooked_post_processor.rb
+++ b/lib/cooked_post_processor.rb
@@ -69,7 +69,7 @@ class CookedPostProcessor
     @doc.css("img[src^='data']") -
     # minus, image inside oneboxes
     oneboxed_images -
-    # minux, images inside quotes
+    # minus, images inside quotes
     @doc.css(".quote img")
   end