Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: sharing popup not showing on macos/chrome 

Despite `navigator.share` being defined the call was failing with this error:

```
sharing DOMException: Internal error: could not connect to Web Share interface.
```
This commit is contained in:
Joffrey JAFFEUX 2018-06-05 01:18:57 +02:00
parent 474ff94df3
commit 40b3efacaa
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/assets/javascripts/discourse/components/share-popup.js.es6
View File

@ -83,10 +83,7 @@ export default Ember.Component.extend({
_webShare(url) { _webShare(url) {
// We can pass title and text too, but most share targets do their own oneboxing // We can pass title and text too, but most share targets do their own oneboxing
navigator.share({ return navigator.share({ url });
url: url
})
.catch((error) => console.warn('Error sharing', error));
}, },
didInsertElement() { didInsertElement() {
@ -118,7 +115,13 @@ export default Ember.Component.extend({
// use native webshare only when the user clicks on the "chain" icon // use native webshare only when the user clicks on the "chain" icon
// navigator.share needs HTTPS, returns undefined on HTTP // navigator.share needs HTTPS, returns undefined on HTTP
if (navigator.share && !$currentTarget.hasClass('post-date')) { if (navigator.share && !$currentTarget.hasClass('post-date')) {
this._webShare(url); this._webShare(url)
.catch(error => {
console.warn('Error sharing', error);
// if navigator fails for unexpected reason fallback to popup
this._showUrl($currentTarget, url);
});
} else { } else {
this._showUrl($currentTarget, url); this._showUrl($currentTarget, url);
} }