Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Prefer `create!` over `create` when not checking return value.

This commit is contained in:
Guo Xiang Tan 2019-05-09 15:10:24 +08:00
parent 626808e100
commit 414a36184b
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
db/fixtures/600_themes.rb
View File

@ -7,13 +7,15 @@ if !Theme.exists?
dark_scheme ||= ColorScheme.create_from_base(name: name, via_wizard: true, base_scheme_id: "Dark")
name = I18n.t('color_schemes.dark_theme_name')
_dark_theme = Theme.create(name: name, user_id: -1,
color_scheme_id: dark_scheme.id,
user_selectable: true)
_dark_theme = Theme.create!(
name: name, user_id: -1,
color_scheme_id: dark_scheme.id,
user_selectable: true
)
name = I18n.t('color_schemes.default_theme_name')
default_theme = Theme.create(name: name, user_id: -1,
user_selectable: true)
default_theme = Theme.create!(name: name, user_id: -1, user_selectable: true)
default_theme.set_default!
end

7
lib/wizard/builder.rb
View File

@ -167,7 +167,12 @@ class Wizard
theme = themes.find(&:default?)
theme ||= themes.first
theme ||= Theme.create(name: name, user_id: @wizard.user.id, color_scheme_id: scheme.id)
theme ||= Theme.create!(
name: name,
user_id: @wizard.user.id,
color_scheme_id: scheme.id
)
theme.set_default!
end
end