From 4191d97d48e2451ff583ed808dee081544a34d14 Mon Sep 17 00:00:00 2001
From: Sam <sam.saffron@gmail.com>
Date: Thu, 7 May 2015 12:14:12 +1000
Subject: [PATCH] FIX: missing titles and aria-labels on sharing links

---
 .../javascripts/discourse/initializers/sharing-sources.js.es6 | 4 ++++
 .../discourse/templates/components/share-source.hbs           | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/app/assets/javascripts/discourse/initializers/sharing-sources.js.es6 b/app/assets/javascripts/discourse/initializers/sharing-sources.js.es6
index e48f4a9d12c..803717002c6 100644
--- a/app/assets/javascripts/discourse/initializers/sharing-sources.js.es6
+++ b/app/assets/javascripts/discourse/initializers/sharing-sources.js.es6
@@ -19,12 +19,14 @@ export default {
         return "http://twitter.com/intent/tweet?url=" + encodeURIComponent(link) + "&text=" + encodeURIComponent(title);
       },
       shouldOpenInPopup: true,
+      title: I18n.t('share.twitter'),
       popupHeight: 265
     });
 
     Sharing.addSource({
       id: 'facebook',
       faIcon: 'fa-facebook-square',
+      title: I18n.t('share.facebook'),
       generateUrl: function(link, title) {
         return "http://www.facebook.com/sharer.php?u=" + encodeURIComponent(link) + '&t=' + encodeURIComponent(title);
       },
@@ -34,6 +36,7 @@ export default {
     Sharing.addSource({
       id: 'google+',
       faIcon: 'fa-google-plus-square',
+      title: I18n.t('share.google+'),
       generateUrl: function(link) {
         return "https://plus.google.com/share?url=" + encodeURIComponent(link);
       },
@@ -44,6 +47,7 @@ export default {
     Sharing.addSource({
       id: 'email',
       faIcon: 'fa-envelope-square',
+      title: I18n.t('share.email'),
       generateUrl: function(link, title) {
         return "mailto:?to=&subject=" + encodeURIComponent('[' + Discourse.SiteSettings.title + '] ' + title) + "&body=" + encodeURIComponent(link);
       }
diff --git a/app/assets/javascripts/discourse/templates/components/share-source.hbs b/app/assets/javascripts/discourse/templates/components/share-source.hbs
index aca17c8b792..87248269b72 100644
--- a/app/assets/javascripts/discourse/templates/components/share-source.hbs
+++ b/app/assets/javascripts/discourse/templates/components/share-source.hbs
@@ -1,4 +1,4 @@
-<a href {{action "share" source}} {{bind-attr title="title"}}>
+<a href {{action "share" source}} title="{{unbound source.title}}" aria-label="{{unbound source.title}}" >
   {{#if source.faIcon}}
     <i {{bind-attr class=":fa source.faIcon"}}></i>
   {{else}}