Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: ensures we have data to compute average (#7685)

This commit is contained in:
Joffrey JAFFEUX 2019-06-04 11:21:55 +02:00 committed by GitHub
parent b79d02ff48
commit 4283281397
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/assets/javascripts/admin/components/admin-report-table.js.es6
View File

@ -31,9 +31,14 @@ export default Ember.Component.extend({
return reportTotal && total && twoColumns; return reportTotal && total && twoColumns;
}, },
@computed("model.average", "totalsForSample.1.value", "twoColumns") @computed("model.{average,data}", "totalsForSample.1.value", "twoColumns")
showAverage(reportAverage, totalValue, twoColumns) { showAverage(model, sampleTotalValue, hasTwoColumns) {
return reportAverage && totalValue && twoColumns; return (
model.average &&
model.data.length > 0 &&
sampleTotalValue &&
hasTwoColumns
);
}, },
@computed("totalsForSample.1.value", "model.data.length") @computed("totalsForSample.1.value", "model.data.length")