From 42f62a9e63a095e5d8fba300fe795e1f5ce3f600 Mon Sep 17 00:00:00 2001
From: Bianca Nenciu <nbianca@users.noreply.github.com>
Date: Wed, 5 Aug 2020 10:39:54 +0300
Subject: [PATCH] FIX: Shows all_results if current settings category has no
 results (#10358)

Searching for a specific setting only showed results from the current selected category. Before fixing fd02856, it automatically redirected the user to all_results. This was a problem because the redirect always happened and there was no way to share a link to a specific category.

The fix to this bug is to simply redirect the user to all_results if there are no results to be displayed.
---
 .../admin/controllers/admin-site-settings.js     |  8 ++++++++
 .../acceptance/admin-site-settings-test.js       | 16 ++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/app/assets/javascripts/admin/controllers/admin-site-settings.js b/app/assets/javascripts/admin/controllers/admin-site-settings.js
index cfb40d34d03..0dab07cf97d 100644
--- a/app/assets/javascripts/admin/controllers/admin-site-settings.js
+++ b/app/assets/javascripts/admin/controllers/admin-site-settings.js
@@ -93,6 +93,14 @@ export default Controller.extend({
     all.hasMore = matches.length > 30;
     all.count = all.hasMore ? "30+" : matches.length;
 
+    const categoryMatches = matchesGroupedByCategory.findBy(
+      "nameKey",
+      category
+    );
+    if (!categoryMatches || categoryMatches.count === 0) {
+      category = "all_results";
+    }
+
     this.set("visibleSiteSettings", matchesGroupedByCategory);
     this.transitionToRoute(
       "adminSiteSettingsCategory",
diff --git a/test/javascripts/acceptance/admin-site-settings-test.js b/test/javascripts/acceptance/admin-site-settings-test.js
index 15778ecddf1..e0cd4ccfa75 100644
--- a/test/javascripts/acceptance/admin-site-settings-test.js
+++ b/test/javascripts/acceptance/admin-site-settings-test.js
@@ -119,3 +119,19 @@ QUnit.test("category name is preserved", async assert => {
   await visit("admin/site_settings/category/login?filter=test");
   assert.equal(currentURL(), "admin/site_settings/category/login?filter=test");
 });
+
+QUnit.test("shows all_results if current category has none", async assert => {
+  await visit("admin/site_settings");
+
+  await click(".admin-nav .basic a");
+  assert.equal(currentURL(), "/admin/site_settings/category/basic");
+
+  await fillIn("#setting-filter", "menu");
+  assert.equal(currentURL(), "/admin/site_settings/category/basic?filter=menu");
+
+  await fillIn("#setting-filter", "contact");
+  assert.equal(
+    currentURL(),
+    "/admin/site_settings/category/all_results?filter=contact"
+  );
+});