FEATURE: enable tagging by default (#13175)
Over the years we have found that a few communities never discovered tags. Instead of having them default off we now have them default on, ensuring that everyone finds out about them. Co-authored-by: Dan Ungureanu <dan@ungureanu.me>
This commit is contained in:
parent
3477c8a2a9
commit
435c4817cb
|
@ -2396,7 +2396,7 @@ user_api:
|
|||
tags:
|
||||
tagging_enabled:
|
||||
client: true
|
||||
default: false
|
||||
default: true
|
||||
refresh: true
|
||||
tag_style:
|
||||
client: true
|
||||
|
|
|
@ -0,0 +1,25 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
class SetTaggingEnabled < ActiveRecord::Migration[6.1]
|
||||
def up
|
||||
result = execute <<~SQL
|
||||
SELECT created_at
|
||||
FROM schema_migration_details
|
||||
ORDER BY created_at
|
||||
LIMIT 1
|
||||
SQL
|
||||
|
||||
# keep tagging disabled for existing sites
|
||||
if result.first['created_at'].to_datetime < 1.hour.ago
|
||||
execute <<~SQL
|
||||
INSERT INTO site_settings(name, data_type, value, created_at, updated_at)
|
||||
VALUES('tagging_enabled', 5, 'f', NOW(), NOW())
|
||||
ON CONFLICT (name) DO NOTHING
|
||||
SQL
|
||||
end
|
||||
end
|
||||
|
||||
def down
|
||||
raise ActiveRecord::IrreversibleMigration
|
||||
end
|
||||
end
|
|
@ -106,6 +106,7 @@ describe Search do
|
|||
|
||||
it "includes custom tables" do
|
||||
begin
|
||||
SiteSetting.tagging_enabled = false
|
||||
expect(Search.execute("test").posts[0].topic.association(:category).loaded?).to be true
|
||||
expect(Search.execute("test").posts[0].topic.association(:tags).loaded?).to be false
|
||||
|
||||
|
|
|
@ -279,6 +279,36 @@
|
|||
"type": "array",
|
||||
"items": [
|
||||
|
||||
]
|
||||
},
|
||||
"watching_tags": {
|
||||
"type": "array",
|
||||
"items": [
|
||||
|
||||
]
|
||||
},
|
||||
"watching_first_post_tags": {
|
||||
"type": "array",
|
||||
"items": [
|
||||
|
||||
]
|
||||
},
|
||||
"tracking_tags": {
|
||||
"type": "array",
|
||||
"items": [
|
||||
|
||||
]
|
||||
},
|
||||
"regular_tags": {
|
||||
"type": "array",
|
||||
"items": [
|
||||
|
||||
]
|
||||
},
|
||||
"muted_tags": {
|
||||
"type": "array",
|
||||
"items": [
|
||||
|
||||
]
|
||||
}
|
||||
},
|
||||
|
|
|
@ -196,8 +196,6 @@ describe TopicViewSerializer do
|
|||
fab!(:staff_tag_group) { Fabricate(:tag_group, permissions: { "staff" => 1 }, tag_names: [hidden_tag.name]) }
|
||||
|
||||
before do
|
||||
SiteSetting.tagging_enabled = true
|
||||
hidden_tag.tag_groups << staff_tag_group
|
||||
topic.tags << hidden_tag
|
||||
end
|
||||
|
||||
|
@ -218,7 +216,6 @@ describe TopicViewSerializer do
|
|||
fab!(:tag3) { Fabricate(:tag, name: 'atag', topic_count: 3) }
|
||||
|
||||
before do
|
||||
SiteSetting.tagging_enabled = true
|
||||
topic.tags << tag1
|
||||
topic.tags << tag2
|
||||
topic.tags << tag3
|
||||
|
|
Loading…
Reference in New Issue