From 47c1cc95dd532dee4bebb7caaafcf2bf4927a63f Mon Sep 17 00:00:00 2001
From: Yana Agun Siswanto <yana.developer@gmail.com>
Date: Thu, 30 Mar 2017 01:49:54 +0700
Subject: [PATCH] Refactor `setSearchTerm`, to be reused on `noSortQ`

---
 .../controllers/full-page-search.js.es6       | 25 ++++++++-----------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/app/assets/javascripts/discourse/controllers/full-page-search.js.es6 b/app/assets/javascripts/discourse/controllers/full-page-search.js.es6
index c6379ba1ab2..a6751b639ea 100644
--- a/app/assets/javascripts/discourse/controllers/full-page-search.js.es6
+++ b/app/assets/javascripts/discourse/controllers/full-page-search.js.es6
@@ -75,14 +75,7 @@ export default Ember.Controller.extend({
 
   @computed('q')
   noSortQ(q) {
-    if (q) {
-      SortOrders.forEach((order) => {
-        if (q.indexOf(order.term) > -1){
-          q = q.replace(order.term, "");
-          q = q.trim();
-        }
-      });
-    }
+    q = this.cleanTerm(q);
     return escapeExpression(q);
   },
 
@@ -90,19 +83,23 @@ export default Ember.Controller.extend({
 
   setSearchTerm(term) {
     this._searchOnSortChange = false;
+    term = this.cleanTerm(term);
+    this._searchOnSortChange = true;
+    this.set('searchTerm', term);
+  },
+
+  cleanTerm(term) {
     if (term) {
       SortOrders.forEach(order => {
-        let term_start      = term.indexOf(order.term)
-        let char_after_term = term[term_start + (order.term || '').length]
-        if (term_start > -1 && (!char_after_term || char_after_term.match(/\s/))){
+        let matches = term.match(new RegExp(`${order.term}\\b`));
+        if (matches) {
           this.set('sortOrder', order.id);
-          term = term.replace(order.term, "");
+          term = term.replace(new RegExp(`${order.term}\\b`, 'g'), "");
           term = term.trim();
         }
       });
     }
-    this._searchOnSortChange = true;
-    this.set('searchTerm', term);
+    return term;
   },
 
   @observes('sortOrder')