Stub the TopTopic.topics_per_period so the logic is fully tested

This commit is contained in:
cpradio 2016-10-12 19:28:54 -04:00 committed by GitHub
parent 9cbf7d036a
commit 489e1bf643
1 changed files with 10 additions and 10 deletions

View File

@ -73,29 +73,29 @@ describe SiteSetting do
context "has_enough_top_topics" do context "has_enough_top_topics" do
SiteSetting.topics_per_period_in_top_page = 2
SiteSetting.top_page_default_timeframe = 'daily'
before do before do
SiteSetting.expects(:min_redirected_to_top_period).returns(:daily) SiteSetting.topics_per_period_in_top_page = 2
SiteSetting.top_page_default_timeframe = 'daily'
TopTopic.stubs(:topics_per_period).with(:daily).returns(3)
TopTopic.refresh!
end end
it "should_return_a_time_period" do it "should_return_a_time_period" do
expect(SiteSetting.min_redirected_to_top_period(1.days.ago)).not_to eq(nil) expect(SiteSetting.min_redirected_to_top_period(1.days.ago)).to eq(:daily)
end end
end end
context "does_not_have_enough_top_topics" do context "does_not_have_enough_top_topics" do
SiteSetting.topics_per_period_in_top_page = 20
SiteSetting.top_page_default_timeframe = 'daily'
before do before do
SiteSetting.expects(:min_redirected_to_top_period).returns(nil) SiteSetting.topics_per_period_in_top_page = 20
SiteSetting.top_page_default_timeframe = 'daily'
TopTopic.stubs(:topics_per_period).with(:daily).returns(1)
TopTopic.refresh!
end end
it "should_return_nil" do it "should_return_a_time_period" do
expect(SiteSetting.min_redirected_to_top_period(1.days.ago)).to eq(nil) expect(SiteSetting.min_redirected_to_top_period(1.days.ago)).to eq(nil)
end end