Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Introduce `home-logo-image-url` value transformer (#28189) 

Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
This commit is contained in:
David Taylor 2024-08-01 13:43:18 +01:00 committed by GitHub
parent 5357f0175e
commit 492a45da37
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 42 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
app/assets/javascripts/discourse/app/components/header/home-logo.gjs
View File

@ -55,23 +55,27 @@ export default class HomeLogo extends Component {
}
logoResolver(name, opts = {}) {
// get alternative logos for browser dark dark mode switching
if (opts.dark) {
return this.siteSettings[`site_${name}_dark_url`];
}
let url;
// try dark logos first when color scheme is dark
// this is independent of browser dark mode
// hence the fallback to normal logos
if (this.session.defaultColorSchemeIsDark) {
return (
if (opts.dark) {
// get alternative logos for browser dark dark mode switching
url = this.siteSettings[`site_${name}_dark_url`];
} else if (this.session.defaultColorSchemeIsDark) {
// try dark logos first when color scheme is dark
// this is independent of browser dark mode
// hence the fallback to normal logos
url =
this.siteSettings[`site_${name}_dark_url`] ||
this.siteSettings[`site_${name}_url`] ||
""
);
"";
} else {
url = this.siteSettings[`site_${name}_url`] || "";
}
return this.siteSettings[`site_${name}_url`] || "";
return applyValueTransformer("home-logo-image-url", url, {
name,
dark: opts.dark,
});
}
@action

1
app/assets/javascripts/discourse/app/lib/transformer/registry.js
View File

@ -7,4 +7,5 @@ export const VALUE_TRANSFORMERS = Object.freeze([
// use only lowercase names
"header-notifications-avatar-size",
"home-logo-href",
"home-logo-image-url",
]);

25
app/assets/javascripts/discourse/tests/acceptance/transformers/home-logo-image-url-test.js Normal file
View File

@ -0,0 +1,25 @@
import { visit } from "@ember/test-helpers";
import { test } from "qunit";
import { withPluginApi } from "discourse/lib/plugin-api";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
acceptance("home-logo-image-url transformer", function () {
test("applying a value transformation", async function (assert) {
withPluginApi("1.34.0", (api) => {
api.registerValueTransformer(
"home-logo-image-url",
({ value }) => "/transformed" + value
);
});
await visit("/");
assert
.dom("#site-logo")
.hasAttribute(
"src",
"/transformed/assets/logo.png",
"it transforms the logo url"
);
});
});