From 494379201d8e2927a08f7b3656eb7d1f2949d044 Mon Sep 17 00:00:00 2001
From: Sam Saffron <sam.saffron@gmail.com>
Date: Fri, 6 Mar 2020 12:57:12 +1100
Subject: [PATCH] DEV: attempt to stabilize flaky spec

Spec was checking implementation when it did not need to, temp file was blank
so optimized image should be blank
---
 spec/models/optimized_image_spec.rb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/spec/models/optimized_image_spec.rb b/spec/models/optimized_image_spec.rb
index a7c8e2e3521..e90029bec3c 100644
--- a/spec/models/optimized_image_spec.rb
+++ b/spec/models/optimized_image_spec.rb
@@ -312,9 +312,10 @@ describe OptimizedImage do
         end
       end
 
-      context "when an error happened while generatign the thumbnail" do
+      context "when we have a bad file returned" do
         it "returns nil" do
-          OptimizedImage.expects(:resize).returns(false)
+          # tempfile is empty
+          # this can not be resized
           expect(OptimizedImage.create_for(s3_upload, 100, 200)).to eq(nil)
         end
       end