From 4a08c2396513e12f7857172b4734317fbbdf39f5 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Fri, 28 Apr 2023 17:58:41 +0200 Subject: [PATCH] DEV: Show select-kit deprecations in non-dev envs (#21297) We should have them in CI ;) (silenced for now, fixing them is not a priority) --- .../discourse/config/deprecation-workflow.js | 1 + .../select-kit/addon/components/select-kit.js | 16 +++++----------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/app/assets/javascripts/discourse/config/deprecation-workflow.js b/app/assets/javascripts/discourse/config/deprecation-workflow.js index 23521118eaf..b7dc6257241 100644 --- a/app/assets/javascripts/discourse/config/deprecation-workflow.js +++ b/app/assets/javascripts/discourse/config/deprecation-workflow.js @@ -8,5 +8,6 @@ globalThis.deprecationWorkflow.config = { { handler: "silence", matchId: "routing.transition-methods" }, { handler: "silence", matchId: "route-disconnect-outlet" }, { handler: "silence", matchId: "this-property-fallback" }, + { handler: "silence", matchId: "discourse.select-kit" }, ], }; diff --git a/app/assets/javascripts/select-kit/addon/components/select-kit.js b/app/assets/javascripts/select-kit/addon/components/select-kit.js index 7330ce0e7b1..75f2e876e30 100644 --- a/app/assets/javascripts/select-kit/addon/components/select-kit.js +++ b/app/assets/javascripts/select-kit/addon/components/select-kit.js @@ -1083,17 +1083,11 @@ export default Component.extend( }, _deprecated(text) { - const discourseSetup = document.getElementById("data-discourse-setup"); - if ( - discourseSetup && - discourseSetup.getAttribute("data-environment") === "development" - ) { - deprecated(text, { - since: "v2.4.0", - dropFrom: "2.9.0.beta1", - id: "discourse.select-kit", - }); - } + deprecated(text, { + since: "v2.4.0", + dropFrom: "2.9.0.beta1", + id: "discourse.select-kit", + }); }, _deprecateValueAttribute() {