From 4b9061ae3facd3f9ff8ea372eed11af7834e5b77 Mon Sep 17 00:00:00 2001 From: Canapin Date: Fri, 14 Apr 2023 04:06:12 +0200 Subject: [PATCH] UX: Remove color attribute from `` tag (#20429) As a single example, if a `` tag is wrapped by a `` link, it doesn't inherit the link color: `[:question: **Support**](https://meta.discourse.org)` It's because the `` tag has a `color: var(--primary);` CSS rule which seems superfluous. If we disable it, the `` tag inherits all the normal colors (including the link color :ok_hand:). The direct `` parent that assigns the text color is `` (can't go higher!) which has an identical `color: var(--primary);`. WCAG palettes don't seem to assign specific colors in this context. It seems fairly safe to remove `color: var(--primary);` from `` so it won't interfere anymore with its content. --- app/assets/stylesheets/common/base/topic-post.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/app/assets/stylesheets/common/base/topic-post.scss b/app/assets/stylesheets/common/base/topic-post.scss index ab8df55ddc3..c0d5be088de 100644 --- a/app/assets/stylesheets/common/base/topic-post.scss +++ b/app/assets/stylesheets/common/base/topic-post.scss @@ -1058,7 +1058,6 @@ kbd { border-bottom-width: 2px; border-radius: 3px; box-sizing: border-box; - color: var(--primary); display: inline-flex; gap: 0 0.5em; // space between text and images/emoji font-size: var(--font-down-1);