Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: Improve UI of group delete dialog (#19292)

This commit is contained in:
Penar Musaraj 2022-12-01 23:01:25 -05:00 committed by GitHub
parent 9b5bc60325
commit 4c037b9ba3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/app/controllers/group.js
View File

@ -137,7 +137,8 @@ export default Controller.extend({
this.set("destroying", true);
const model = this.model;
let message = I18n.t("admin.groups.delete_confirm");
const title = I18n.t("admin.groups.delete_confirm");
let message = null;
if (model.has_messages && model.message_count > 0) {
message = I18n.t("admin.groups.delete_with_messages_confirm", {
@ -145,7 +146,8 @@ export default Controller.extend({
});
}
this.dialog.yesNoConfirm({
this.dialog.deleteConfirm({
title,
message,
didConfirm: () => {
model

6
config/locales/client.en.yml
View File

@ -4443,10 +4443,10 @@ en:
about: "Edit your group membership and names here"
group_members: "Group members"
delete: "Delete"
delete_confirm: "Delete this group?"
delete_confirm: "Are you sure you want to delete this group?"
delete_with_messages_confirm:
one: "Deleting this group will cause %{count} message to be orphaned, group members will no longer have access to it.<br><br>Are you sure?"
other: "Deleting this group will cause %{count} messages to be orphaned, group members will no longer have access to them.<br><br>Are you sure?"
one: "Deleting this group will cause %{count} message to be orphaned, group members will no longer have access to it."
other: "Deleting this group will cause %{count} messages to be orphaned, group members will no longer have access to them."
delete_failed: "Unable to delete group. If this is an automatic group, it cannot be destroyed."
delete_automatic_group: This is an automatic group and cannot be deleted.
delete_owner_confirm: "Remove owner privilege for '%{username}'?"