diff --git a/app/assets/javascripts/discourse-common/addon/lib/icon-library.js b/app/assets/javascripts/discourse-common/addon/lib/icon-library.js index e6c740b353a..edf8160c3e4 100644 --- a/app/assets/javascripts/discourse-common/addon/lib/icon-library.js +++ b/app/assets/javascripts/discourse-common/addon/lib/icon-library.js @@ -149,7 +149,7 @@ registerIconRenderer({ if (params.label) { html += " aria-hidden='true'"; } - html += ` xmlns="${SVG_NAMESPACE}">`; + html += ` xmlns="${SVG_NAMESPACE}">`; if (params.label) { html += `${escape(params.label)}`; } @@ -178,10 +178,7 @@ registerIconRenderer({ }, [ h("use", { - "xlink:href": attributeHook( - "http://www.w3.org/1999/xlink", - `#${escape(id)}` - ), + href: attributeHook("http://www.w3.org/1999/xlink", `#${escape(id)}`), namespace: SVG_NAMESPACE, }), ] diff --git a/app/assets/javascripts/discourse/app/lib/plugin-api.js b/app/assets/javascripts/discourse/app/lib/plugin-api.js index 5d7d924a72f..b897b219f4e 100644 --- a/app/assets/javascripts/discourse/app/lib/plugin-api.js +++ b/app/assets/javascripts/discourse/app/lib/plugin-api.js @@ -234,7 +234,7 @@ class PluginApi { * * // for the place in code that render a string * string() { - * return ""; + * return ""; * }, * * // for the places in code that render virtual dom elements @@ -244,7 +244,7 @@ class PluginApi { * namespace: "http://www.w3.org/2000/svg" * },[ * h("use", { - * "xlink:href": attributeHook("http://www.w3.org/1999/xlink", `#far-smile`), + * "href": attributeHook("http://www.w3.org/1999/xlink", `#far-smile`), * namespace: "http://www.w3.org/2000/svg" * })] * ); diff --git a/app/assets/javascripts/discourse/app/templates/components/login-buttons.hbs b/app/assets/javascripts/discourse/app/templates/components/login-buttons.hbs index cba646b2be3..f334a041090 100644 --- a/app/assets/javascripts/discourse/app/templates/components/login-buttons.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/login-buttons.hbs @@ -1,7 +1,7 @@ {{#each buttons as |b|}}
+ HTML expect(cpp).to be_dirty @@ -496,7 +496,7 @@ describe CookedPostProcessor do let(:cooked_html) do <<~HTML HTML end @@ -578,7 +578,7 @@ describe CookedPostProcessor do cpp.post_process expect(cpp.html).to match_html <<~HTML - + HTML expect(cpp).to be_dirty @@ -609,7 +609,7 @@ describe CookedPostProcessor do cpp.post_process expect(cpp.html). to match_html <<~HTML - + HTML expect(cpp).to be_dirty @@ -620,7 +620,7 @@ describe CookedPostProcessor do cpp.post_process expect(cpp.html).to match_html <<~HTML - + HTML end @@ -646,7 +646,7 @@ describe CookedPostProcessor do cpp.post_process expect(cpp.html).to match_html <<~HTML - + HTML expect(cpp).to be_dirty @@ -674,7 +674,7 @@ describe CookedPostProcessor do cpp.post_process expect(cpp.html).to match_html <<~HTML - + HTML expect(cpp).to be_dirty @@ -702,7 +702,7 @@ describe CookedPostProcessor do cpp.post_process expect(cpp.html).to match_html <<~HTML - + HTML expect(cpp).to be_dirty diff --git a/spec/helpers/user_notifications_helper_spec.rb b/spec/helpers/user_notifications_helper_spec.rb index 746a9b71f6c..985afda2aed 100644 --- a/spec/helpers/user_notifications_helper_spec.rb +++ b/spec/helpers/user_notifications_helper_spec.rb @@ -35,7 +35,7 @@ describe UserNotificationsHelper do let(:lightbox_image) do <<~HTML HTML end diff --git a/spec/lib/upload_creator_spec.rb b/spec/lib/upload_creator_spec.rb index 720d224e5f4..2be20fe13ae 100644 --- a/spec/lib/upload_creator_spec.rb +++ b/spec/lib/upload_creator_spec.rb @@ -561,10 +561,10 @@ RSpec.describe UploadCreator do