From 4c8939d530ec0d284375d5f8177fdfcf81c60e8a Mon Sep 17 00:00:00 2001
From: OsamaSayegh <asooomaasoooma90@gmail.com>
Date: Mon, 11 Jun 2018 07:50:08 +0300
Subject: [PATCH] REFACTOR: admin email controller specs to requests (#5962)

---
 .../admin/email_controller_spec.rb            | 124 ++++++++----------
 1 file changed, 58 insertions(+), 66 deletions(-)
 rename spec/{controllers => requests}/admin/email_controller_spec.rb (53%)

diff --git a/spec/controllers/admin/email_controller_spec.rb b/spec/requests/admin/email_controller_spec.rb
similarity index 53%
rename from spec/controllers/admin/email_controller_spec.rb
rename to spec/requests/admin/email_controller_spec.rb
index a8f838f64dc..ff8b46e71b6 100644
--- a/spec/controllers/admin/email_controller_spec.rb
+++ b/spec/requests/admin/email_controller_spec.rb
@@ -1,26 +1,28 @@
 require 'rails_helper'
 
 describe Admin::EmailController do
+  let(:admin) { Fabricate(:admin) }
+
+  before do
+    sign_in(admin)
+  end
 
   it "is a subclass of AdminController" do
     expect(Admin::EmailController < Admin::AdminController).to eq(true)
   end
 
-  let!(:user) { log_in(:admin) }
-
-  context '.index' do
+  describe '#index' do
     before do
-      subject
+      Admin::EmailController.any_instance
         .expects(:action_mailer_settings)
         .returns(
           username: 'username',
           password: 'secret'
         )
-
-      get :index, format: :json
     end
 
     it 'does not include the password in the response' do
+      get "/admin/email.json"
       mail_settings = JSON.parse(response.body)['settings']
 
       expect(
@@ -29,84 +31,74 @@ describe Admin::EmailController do
     end
   end
 
-  context '.sent' do
-    before do
-      get :sent, format: :json
-    end
-
-    subject { response }
-    it { is_expected.to be_successful }
-  end
-
-  context '.skipped' do
-    before do
-      get :skipped, format: :json
-    end
-
-    subject { response }
-    it { is_expected.to be_successful }
-  end
-
-  context '.test' do
-    it 'raises an error without the email parameter' do
-      expect do
-        post :test, format: :json
-      end.to raise_error(ActionController::ParameterMissing)
-    end
-
-    context 'with an email address' do
-      it 'enqueues a test email job' do
-        job_mock = mock
-        Jobs::TestEmail.expects(:new).returns(job_mock)
-        job_mock.expects(:execute).with(to_address: 'eviltrout@test.domain')
-        post :test, params: { email_address: 'eviltrout@test.domain' }, format: :json
-      end
-    end
-  end
-
-  context '.preview_digest' do
-    it 'raises an error without the last_seen_at parameter' do
-      expect do
-        get :preview_digest, format: :json
-      end.to raise_error(ActionController::ParameterMissing)
-    end
-
-    it "previews the digest" do
-      get :preview_digest, params: {
-        last_seen_at: 1.week.ago, username: user.username
-      }, format: :json
-
+  describe '#sent' do
+    it "succeeds" do
+      get "/admin/email/sent.json"
       expect(response.status).to eq(200)
     end
   end
 
-  context '#handle_mail' do
-    before do
-      log_in_user(Fabricate(:admin))
-    end
-
-    it 'should enqueue the right job' do
-      expect { post :handle_mail, params: { email: email('cc') }, format: :json }
-        .to change { Jobs::ProcessEmail.jobs.count }.by(1)
+  describe '#skipped' do
+    it "succeeds" do
+      get "/admin/email/skipped.json"
+      expect(response.status).to eq(200)
     end
   end
 
-  context '.rejected' do
+  describe '#test' do
+    it 'raises an error without the email parameter' do
+      post "/admin/email/test.json"
+      expect(response.status).to eq(400)
+    end
+
+    context 'with an email address' do
+      it 'enqueues a test email job' do
+        post "/admin/email/test.json", params: { email_address: 'eviltrout@test.domain' }
+        expect(response.status).to eq(200)
+        expect(ActionMailer::Base.deliveries.map(&:to).flatten).to include('eviltrout@test.domain')
+      end
+    end
+  end
+
+  describe '#preview_digest' do
+    it 'raises an error without the last_seen_at parameter' do
+      get "/admin/email/preview-digest.json"
+      expect(response.status).to eq(400)
+    end
+
+    it "previews the digest" do
+      get "/admin/email/preview-digest.json", params: {
+        last_seen_at: 1.week.ago, username: admin.username
+      }
+      expect(response.status).to eq(200)
+    end
+  end
+
+  describe '#handle_mail' do
+    it 'should enqueue the right job' do
+      expect { post "/admin/email/handle_mail.json", params: { email: email('cc') } }
+        .to change { Jobs::ProcessEmail.jobs.count }.by(1)
+      expect(response.status).to eq(200)
+    end
+  end
+
+  describe '#rejected' do
     it 'should provide a string for a blank error' do
       Fabricate(:incoming_email, error: "")
-      get :rejected, format: :json
+      get "/admin/email/rejected.json"
+      expect(response.status).to eq(200)
       rejected = JSON.parse(response.body)
       expect(rejected.first['error']).to eq(I18n.t("emails.incoming.unrecognized_error"))
     end
   end
 
-  context '.incoming' do
+  describe '#incoming' do
     it 'should provide a string for a blank error' do
       incoming_email = Fabricate(:incoming_email, error: "")
-      get :incoming, params: { id: incoming_email.id }, format: :json
+      get "/admin/email/incoming/#{incoming_email.id}.json"
+      expect(response.status).to eq(200)
       incoming = JSON.parse(response.body)
       expect(incoming['error']).to eq(I18n.t("emails.incoming.unrecognized_error"))
     end
   end
-
 end