DEV: use #frozen_string_literal: true on all spec

This change both speeds up specs (less strings to allocate) and helps catch
cases where methods in Discourse are mutating inputs.

Overall we will be migrating everything to use #frozen_string_literal: true
it will take a while, but this is the first and safest move in this direction

spec/components/active_record/connection_adapters/postgresql_fallback_adapter_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'active_record/connection_adapters/postgresql_fallback_adapter'
 

spec/components/admin_confirmation_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'admin_confirmation'
 require 'rails_helper'
 

spec/components/admin_user_index_query_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'admin_user_index_query'
 

spec/components/archetype_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 require 'rails_helper'
 require 'archetype'

spec/components/auth/default_current_user_provider_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'auth/default_current_user_provider'
 

spec/components/auth/facebook_authenticator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Auth::FacebookAuthenticator do

spec/components/auth/github_authenticator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 def auth_token_for(user)

spec/components/auth/google_oauth2_authenticator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Auth::GoogleOAuth2Authenticator do

spec/components/auth/instagram_authenticator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Auth::InstagramAuthenticator do

spec/components/auth/managed_authenticator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Auth::ManagedAuthenticator do

spec/components/auth/open_id_authenticator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Auth::OpenIdAuthenticator do

spec/components/auth/twitter_authenticator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Auth::TwitterAuthenticator do

spec/components/avatar_lookup_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 
 require 'rails_helper'
 require_dependency 'avatar_lookup'

spec/components/cache_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'cache'
 

spec/components/category_badge_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'category_badge'
 

spec/components/common_passwords/common_passwords_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 require_dependency "common_passwords/common_passwords"
 

spec/components/composer_messages_finder_spec.rb

@@ -1,4 +1,6 @@
 # encoding: utf-8
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'composer_messages_finder'
 

spec/components/concern/category_hashtag_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe CategoryHashtag do

spec/components/concern/has_custom_fields_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 
 describe HasCustomFields do

spec/components/concern/has_search_data_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 
 describe HasSearchData do

spec/components/concern/positionable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 
 describe Positionable do

spec/components/concern/searchable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 
 describe Searchable do

spec/components/concern/second_factor_manager_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe SecondFactorManager do

spec/components/content_buffer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'content_buffer'
 

spec/components/cooked_post_processor_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 require "cooked_post_processor"
 require "file_store/s3_store"

spec/components/crawler_detection_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'crawler_detection'
 

spec/components/current_user_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'current_user'
 

spec/components/directory_helper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'directory_helper'
 

spec/components/discourse_diff_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'discourse_diff'
 

spec/components/discourse_event_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'discourse_event'
 

spec/components/discourse_hub_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'discourse_hub'
 

spec/components/discourse_i18n_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'i18n/backend/discourse_i18n'
 require 'translation_override'

spec/components/discourse_plugin_registry_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'discourse_plugin_registry'
 

spec/components/discourse_plugin_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'discourse_plugin'
 

spec/components/discourse_redis_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe DiscourseRedis do

spec/components/discourse_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'discourse'
 

spec/components/discourse_tagging_spec.rb

@@ -1,4 +1,5 @@
 # encoding: UTF-8
+# frozen_string_literal: true
 
 require 'rails_helper'
 require 'discourse_tagging'

spec/components/discourse_updates_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'discourse_updates'
 

spec/components/distributed_memoizer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'distributed_memoizer'
 

spec/components/distributed_mutex_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'distributed_mutex'
 

spec/components/email/email_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'email'
 

spec/components/email/message_builder_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'email/message_builder'
 

spec/components/email/processor_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 require "email/processor"
 

spec/components/email/receiver_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 require "email/receiver"
 

spec/components/email/renderer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'email/renderer'
 

spec/components/email/sender_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'email/sender'
 

spec/components/email/styles_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'email'
 

spec/components/email_cook_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'email_cook'
 require 'pretty_text'
@@ -22,7 +24,7 @@ describe EmailCook do
       Vestibulum feugiat mi vitae turpis tempor dignissim.
     LONG_EMAIL
 
-    long_cooked = <<~LONG_COOKED.strip!
+    long_cooked = (+<<~LONG_COOKED).strip!
       Hello,
       <br>
       <br>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc convallis volutpat
@@ -45,7 +47,7 @@ describe EmailCook do
       Stet clita kasd gubergren.
     LONG_EMAIL
 
-    long_cooked = <<~LONG_COOKED.strip!
+    long_cooked = (+<<~LONG_COOKED).strip!
       Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc convallis volutpat
       risus.
       <br>Nulla ac faucibus quam, quis cursus lorem. Sed rutrum eget nunc sed accumsan.
@@ -70,7 +72,7 @@ describe EmailCook do
       Nunc convallis volutpat risus.
     LONG_EMAIL
 
-    long_cooked = <<~LONG_COOKED.strip!
+    long_cooked = (+<<~LONG_COOKED).strip!
       Lorem ipsum dolor sit amet, consectetur adipiscing elit.
       <br>
       <br>&lt;form name=&quot;f1&quot; method=&quot;post&quot; action=&quot;test.html&quot; onsubmit=&quot;javascript:showAlert()&quot;&gt;
@@ -94,7 +96,7 @@ describe EmailCook do
       no indentation, but lots       of spaces
     LONG_EMAIL
 
-    long_cooked = <<~LONG_COOKED.strip!
+    long_cooked = (+<<~LONG_COOKED).strip!
       Lorem ipsum dolor sit amet, consectetur adipiscing elit.
       <br>
       <br>#{nbsp}#{nbsp}#{nbsp}#{nbsp}this is indended by 4 spaces

spec/components/email_updater_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'email_updater'
 

spec/components/enum_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'email'
 

spec/components/excerpt_parser_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 require "excerpt_parser"
 

spec/components/fallback_locale_list_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'i18n/backend/fallback_locale_list'
 

spec/components/feed_element_installer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'feed_element_installer'
 require 'rails_helper'
 

spec/components/feed_item_accessor_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rss'
 require 'feed_item_accessor'
 require 'rails_helper'

spec/components/file_helper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'file_helper'
 

spec/components/file_store/base_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'file_store/base_store'
 

spec/components/file_store/local_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'file_store/local_store'
 

spec/components/file_store/s3_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'file_store/s3_store'
 require 'file_store/local_store'

spec/components/filter_best_posts_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'filter_best_posts'
 require 'topic_view'

spec/components/final_destination_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'final_destination'
 

spec/components/flag_query_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'flag_query'
 

spec/components/flag_settings_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'flag_settings'
 

spec/components/freedom_patches/safe_buffer_spec.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency "freedom_patches/safe_buffer"
 
 describe ActiveSupport::SafeBuffer do
   it "can cope with encoding weirdness" do
     buffer = ActiveSupport::SafeBuffer.new
-    buffer << "\330".force_encoding("ASCII-8BIT")
+    buffer << (+"\330").force_encoding("ASCII-8BIT")
     buffer.force_encoding "ASCII-8BIT"
     buffer << "hello\330\271"
-    buffer << "hello#{254.chr}".force_encoding("ASCII-8BIT").freeze
+    buffer << (+"hello#{254.chr}").force_encoding("ASCII-8BIT").freeze
 
     # we pay a cost for force encoding, the h gets dropped
     expect(buffer).to match(/ello.*hello/)

spec/components/freedom_patches/schema_migration_details_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency "freedom_patches/schema_migration_details"
 

spec/components/freedom_patches/translate_accelerator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 
 describe "translate accelerator" do

spec/components/gaps_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'cache'
 

spec/components/global_path_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'global_path'
 

spec/components/guardian/category_guardian_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe CategoryGuardian do

spec/components/guardian/user_guardian_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe UserGuardian do

spec/components/guardian_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 require 'guardian'

spec/components/has_errors_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'has_errors'
 

spec/components/highlight_js/highlight_js_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'highlight_js/highlight_js'
 

spec/components/hijack_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Hijack do

spec/components/html_prettify_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'html_prettify'
 

spec/components/html_to_markdown_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'html_to_markdown'
 

spec/components/image_sizer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'image_sizer'
 

spec/components/import/normalize_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 require_dependency "import/normalize"
 

spec/components/inline_oneboxer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'inline_oneboxer'
 

spec/components/js_locale_helper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'mini_racer'
 

spec/components/json_error_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'json_error'
 

spec/components/letter_avatar_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'letter_avatar'
 

spec/components/method_profiler_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'method_profiler'
 

spec/components/middleware/anonymous_cache_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 require_dependency "middleware/anonymous_cache"
 

spec/components/middleware/request_tracker_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_helper"
 require_dependency "middleware/request_tracker"
 

spec/components/migration/column_dropper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'migration/column_dropper'
 

spec/components/migration/safe_migrate_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'migration/safe_migrate'
 

spec/components/migration/table_dropper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'migration/table_dropper'
 

spec/components/new_post_manager_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'new_post_manager'
 

spec/components/new_post_result_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'new_post_result'
 

spec/components/onebox/engine/flash_video_onebox_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'onebox/engine/flash_video_onebox'
 

spec/components/onebox/engine/whitelisted_generic_onebox_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe Onebox::Engine::WhitelistedGenericOnebox do

spec/components/oneboxer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'oneboxer'
 

spec/components/onpdiff_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'onpdiff'
 

spec/components/pbkdf2_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'pbkdf2'
 
 describe Pbkdf2 do

spec/components/pinned_check_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'pinned_check'
 

spec/components/plain_text_to_markdown_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require 'plain_text_to_markdown'
 

spec/components/plugin/filter_manager_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'plugin/filter_manager'
 

spec/components/plugin/instance_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'plugin/instance'
 

spec/components/plugin/metadata_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 require_dependency 'plugin/metadata'
 

spec/components/post_action_creator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 describe PostActionCreator do