UX: Improve display of short site description in header dropdown (#21628)

app/assets/javascripts/discourse/app/components/sidebar/common/custom-section.hbs

@@ -5,14 +5,8 @@
   @headerActions={{this.section.headerActions}}
   @headerActionsIcon={{this.section.headerActionIcon}}
   @class={{this.section.dragCss}}
+  @sectionDescription={{this.section.description}}
 >
-
-  {{#if this.section.displayShortSiteDescription}}
-    <Sidebar::SectionMessage>
-      {{this.siteSettings.short_site_description}}
-    </Sidebar::SectionMessage>
-  {{/if}}
-
   {{#each this.section.links as |link|}}
     {{#if link.shouldDisplay}}
       {{#if link.external}}

app/assets/javascripts/discourse/app/components/sidebar/section.hbs

@@ -44,6 +44,12 @@
       {{/if}}
     </div>
 
+    {{#if @sectionDescription}}
+      <Sidebar::SectionMessage>
+        {{@sectionDescription}}
+      </Sidebar::SectionMessage>
+    {{/if}}
+
     {{#if this.displaySectionContent}}
       <ul class="sidebar-section-content" id={{this.sidebarSectionContentID}}>
         {{yield}}

app/assets/javascripts/discourse/app/lib/sidebar/community-section.js

@@ -131,8 +131,12 @@ export default class CommunitySection {
     });
   }
 
-  get displayShortSiteDescription() {
+  get description() {
-    return !this.currentUser && !!this.siteSettings.short_site_description;
+    if (!this.currentUser && !!this.siteSettings.short_site_description) {
+      return this.siteSettings.short_site_description;
+    } else {
+      return "";
+    }
   }
 
   get decoratedTitle() {

app/assets/stylesheets/desktop/menu-panel.scss

@@ -52,6 +52,10 @@
         }
       }
     }
+
+    .sidebar-section-message {
+      padding: 0;
+    }
   }
 
   .sidebar-custom-sections .d-icon-globe {

app/assets/stylesheets/mobile/menu-panel.scss

@@ -52,10 +52,6 @@
       padding-top: 0;
       padding-bottom: 0.25em;
     }
-
-    .sidebar-section-message {
-      padding: 0;
-    }
   }
 
   .sidebar-section-wrapper {