Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

UX: also plays notification sounds in group channels (#27176) 

Prior to this fix we were limiting this to 1:1 channels.
This commit is contained in:
Joffrey JAFFEUX 2024-05-24 17:48:07 +02:00 committed by GitHub
parent 971b66e440
commit 5134e74e91
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/chat/assets/javascripts/discourse/services/chat-channel-notification-sound.js
View File

@ -20,10 +20,6 @@ export default class ChatChannelNotificationSound extends Service {
return false; return false;
} }
if (channel.chatable.group) {
return false;
}
if (!this.currentUser.chat_sound) { if (!this.currentUser.chat_sound) {
return false; return false;
} }

7
plugins/chat/test/javascripts/unit/services/chat-channel-notification-sound-test.js
View File

@ -122,13 +122,6 @@ acceptance(
assert.deepEqual(await this.subject.play(channel), false); assert.deepEqual(await this.subject.play(channel), false);
}); });
test("group", async function (assert) {
const channel = buildDirectMessageChannel(getOwner(this));
channel.chatable.group = true;
assert.deepEqual(await this.subject.play(channel), false);
});
test("not idle", async function (assert) { test("not idle", async function (assert) {
const channel = buildDirectMessageChannel(getOwner(this)); const channel = buildDirectMessageChannel(getOwner(this));
resetIdle(); resetIdle();