Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: select-kit components not being hidden.

This commit is contained in:
Guo Xiang Tan 2020-06-04 21:33:57 +08:00 committed by Alan Guo Xiang Tan
parent ad447677ed
commit 52580605d8
4 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/select-kit/addon/templates/components/multi-select.hbs
View File

@ -1,4 +1,4 @@
{{#unless isHidden}}
{{#unless selectKit.isHidden}}
{{component selectKit.options.headerComponent
tabindex=tabindex
value=value

2
app/assets/javascripts/select-kit/addon/templates/components/single-select.hbs
View File

@ -1,4 +1,4 @@
{{#unless isHidden}}
{{#unless selectKit.isHidden}}
{{component selectKit.options.headerComponent
tabindex=tabindex
value=value

4
app/assets/stylesheets/common/select-kit/select-kit.scss
View File

@ -7,10 +7,6 @@
vertical-align: middle;
user-select: none;
&.is-hidden {
display: none !important;
}
&.is-disabled {
pointer-events: none;
}

1
test/javascripts/acceptance/composer-actions-test.js
View File

@ -177,6 +177,7 @@ QUnit.test("hide component if no content", async assert => {
await composerActions.selectRowByValue("reply_as_private_message");
assert.ok(composerActions.el().hasClass("is-hidden"));
assert.equal(composerActions.el().children().length, 0);
await click("button#create-topic");
await composerActions.expand();