From 53adbf70f3ce0d1ef60a3d8e0480dfed710e8d9f Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Wed, 1 Aug 2018 11:49:20 +0800 Subject: [PATCH] FIX: Nav item missing for plugins that don't include a custom filter. --- app/assets/javascripts/discourse/models/nav-item.js.es6 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/models/nav-item.js.es6 b/app/assets/javascripts/discourse/models/nav-item.js.es6 index 6a9a782aeaf..884a9324d0d 100644 --- a/app/assets/javascripts/discourse/models/nav-item.js.es6 +++ b/app/assets/javascripts/discourse/models/nav-item.js.es6 @@ -105,8 +105,7 @@ const NavItem = Discourse.Model.extend({ }); const ExtraNavItem = NavItem.extend({ - @computed("href") - href: href => href, + @computed("href") href: href => href, customFilter: null }); @@ -175,7 +174,8 @@ NavItem.reopenClass({ ); const extraItems = NavItem.extraNavItems.filter(item => { - return item.customFilter && item.customFilter.call(this, category, args); + if (!item.customFilter) return true; + return item.customFilter.call(this, category, args); }); return items.concat(extraItems);