Discource-C/discourse
1
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-07 20:08:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Introduce pg_force_readonly_mode GlobalSetting (#19612)

Browse Source 
This allows the entire cluster to be forced into pg readonly mode. Equivalent to running `Discourse.enable_pg_force_readonly_mode` on the console.
This commit is contained in:
David Taylor 2023-01-19 13:59:11 +00:00 committed by GitHub
parent 998c47cf82
commit 5406e24acb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
config/discourse_defaults.conf
View File

@ -365,3 +365,6 @@ preload_link_header = false
# When using an external upload store, redirect `user_avatar` requests instead of proxying # When using an external upload store, redirect `user_avatar` requests instead of proxying
redirect_avatar_requests = false redirect_avatar_requests = false
# Force the entire cluster into postgres readonly mode. Equivalent to running `Discourse.enable_pg_force_readonly_mode`
pg_force_readonly_mode = false

6
config/initializers/002-rails_failover.rb
View File

@ -69,7 +69,11 @@ if defined?(RailsFailover::ActiveRecord)
end end
RailsFailover::ActiveRecord.register_force_reading_role_callback do RailsFailover::ActiveRecord.register_force_reading_role_callback do
Discourse.redis.exists?(Discourse::PG_READONLY_MODE_KEY, Discourse::PG_FORCE_READONLY_MODE_KEY) GlobalSetting.pg_force_readonly_mode ||
Discourse.redis.exists?(
Discourse::PG_READONLY_MODE_KEY,
Discourse::PG_FORCE_READONLY_MODE_KEY,
)
rescue => e rescue => e
if !e.is_a?(Redis::CannotConnectError) if !e.is_a?(Redis::CannotConnectError)
Rails.logger.warn "#{e.class} #{e.message}: #{e.backtrace.join("\n")}" Rails.logger.warn "#{e.class} #{e.message}: #{e.backtrace.join("\n")}"

2
lib/discourse.rb
View File

@ -691,7 +691,7 @@ module Discourse
end end
def self.readonly_mode?(keys = READONLY_KEYS) def self.readonly_mode?(keys = READONLY_KEYS)
recently_readonly? || Discourse.redis.exists?(*keys) recently_readonly? || GlobalSetting.pg_force_readonly_mode || Discourse.redis.exists?(*keys)
end end
def self.staff_writes_only_mode? def self.staff_writes_only_mode?

6
spec/lib/discourse_spec.rb
View File

@ -300,6 +300,12 @@ RSpec.describe Discourse do
Discourse.disable_readonly_mode(user_readonly_mode_key) Discourse.disable_readonly_mode(user_readonly_mode_key)
expect(Discourse.readonly_mode?).to eq(false) expect(Discourse.readonly_mode?).to eq(false)
end end
it "returns true when forced via global setting" do
expect(Discourse.readonly_mode?).to eq(false)
global_setting :pg_force_readonly_mode, true
expect(Discourse.readonly_mode?).to eq(true)
end
end end
describe ".received_postgres_readonly!" do describe ".received_postgres_readonly!" do