From 558e6a3ff495ca2fd5f7eac66ccb4e64393ee08a Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Mon, 22 Aug 2022 11:21:49 +0800 Subject: [PATCH] Review feedback --- .../javascripts/discourse/app/widgets/topic-admin-menu.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/app/widgets/topic-admin-menu.js b/app/assets/javascripts/discourse/app/widgets/topic-admin-menu.js index 1a03f2f0ff8..1ca2054c78a 100644 --- a/app/assets/javascripts/discourse/app/widgets/topic-admin-menu.js +++ b/app/assets/javascripts/discourse/app/widgets/topic-admin-menu.js @@ -79,7 +79,7 @@ createWidget("topic-admin-menu-button", { let button; if (e === undefined) { - button = document.getElementsByClassName(".keyboard-target-admin-menu"); + button = document.querySelector(".keyboard-target-admin-menu"); } else { button = e.target.closest("button"); } @@ -88,7 +88,7 @@ createWidget("topic-admin-menu-button", { const spacing = 3; const menuWidth = 212; - const rtl = document.querySelectorAll("html.rtl")[0]; + const rtl = document.documentElement.classList.contains("html.rtl"); const buttonDOMRect = button.getBoundingClientRect(); position.outerHeight = buttonDOMRect.height;