DEV: Modernise discovery controller query parameter construction (#17927)

Using `URLSearchParams` means that we don't have to manually encode/join strings

app/assets/javascripts/discourse/app/controllers/discovery.js

@@ -45,17 +45,19 @@ export default Controller.extend({
 
     url += "/top";
 
-    let queryParams = this.router.currentRoute.queryParams;
+    const urlSearchParams = new URLSearchParams();
-    queryParams.period = period;
+
-    if (Object.keys(queryParams).length) {
+    for (const [key, value] of Object.entries(
-      url =
+      this.router.currentRoute.queryParams
-        `${url}?` +
+    )) {
-        Object.keys(queryParams)
+      if (typeof value !== "undefined") {
-          .map((key) => `${key}=${queryParams[key]}`)
+        urlSearchParams.set(key, value);
-          .join("&");
+      }
     }
 
-    return url;
+    urlSearchParams.set("period", period);
+
+    return `${url}?${urlSearchParams.toString()}`;
   },
 
   actions: {