Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Attempt to fix flaky sidebar test (#17852) 

Makes displaying and hiding the list more deterministic.

```
Error: QUnit Test Failure: Exam Partition 1 - Acceptance: Sidebar - Community Section: clicking on more... link
not ok 491 Firefox 91.0 - [722 ms] - Exam Partition 1 - Acceptance: Sidebar - Community Section: clicking on more... link
    ---
        actual: >
            true
        expected: >
            false
        stack: >
            @http://localhost:7357/assets/core-tests.js:9826:14

        message: >
            additional section links are hidden
        negative: >
            false
        browser log: |
```
This commit is contained in:
Alan Guo Xiang Tan 2022-08-10 21:22:55 +08:00 committed by GitHub
parent 5283088269
commit 55fa94f759
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/components/sidebar/more-section-links.js
View File

@ -72,8 +72,8 @@ export default class SidebarMoreSectionLinks extends GlimmerComponent {
}
@action
toggleSectionLinks() {
this.shouldDisplaySectionLinks = !this.shouldDisplaySectionLinks;
toggleSectionLinks(element) {
this.shouldDisplaySectionLinks = element.target.hasAttribute("open");
}
#removeClickEventListener() {