FIX: Embedded topics couldn't update their titles

This commit is contained in:
Robin Ward 2020-04-20 14:27:43 -04:00
parent 8f5314bf98
commit 56a23c68f1
2 changed files with 6 additions and 7 deletions

View File

@ -92,12 +92,10 @@ class TopicEmbed < ActiveRecord::Base
end
if content_sha1 != embed.content_sha1
post.revise(
user,
{ raw: absolutize_urls(url, contents) },
skip_validations: true,
bypass_rate_limiter: true
)
changes = { raw: absolutize_urls(url, contents) }
changes[:title] = title if title.present?
post.revise(user, changes, skip_validations: true, bypass_rate_limiter: true)
embed.update!(content_sha1: content_sha1)
end
end

View File

@ -46,8 +46,9 @@ describe TopicEmbed do
it "Supports updating the post content" do
expect do
TopicEmbed.import(user, url, title, "muhahaha new contents!")
TopicEmbed.import(user, url, "New title received", "muhahaha new contents!")
end.to change { topic_embed.reload.content_sha1 }
expect(topic_embed.topic.title).to eq("New title received")
expect(topic_embed.post.cooked).to match(/new contents/)
end