FIX: Avoid double-encoding featured topic title in user card (#20739)

a373bf2a updated the behavior of `replace-emoji` so that the input is treated as unsafe-by-default. `fancy_title` is already escaped, so we need to mark it as html-safe to avoid it being double-escaped. There is no need to html-safe the result of replace-emoji - it's already done as part of the helper.
2023-03-20 12:47:53 +00:00 · 2023-03-20 12:47:53 +00:00 · 597316125f
parent 80367b827a
commit 597316125f
1 changed files with 2 additions and 2 deletions
--- a/app/assets/javascripts/discourse/app/components/user-card-contents.hbs
+++ b/app/assets/javascripts/discourse/app/components/user-card-contents.hbs
@ -241,8 +241,8 @@
                this.user.featured_topic.slug
                this.user.featured_topic.id
              }}
-            >{{html-safe
-                (replace-emoji this.user.featured_topic.fancy_title)
+            >{{replace-emoji
+                (html-safe this.user.featured_topic.fancy_title)
              }}</LinkTo>
          </div>
        </div>