Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FIX: Avoid double-encoding featured topic title in user card (#20739) 

a373bf2a updated the behavior of `replace-emoji` so that the input is treated as unsafe-by-default. `fancy_title` is already escaped, so we need to mark it as html-safe to avoid it being double-escaped.

There is no need to html-safe the result of replace-emoji - it's already done as part of the helper.
This commit is contained in:
David Taylor 2023-03-20 12:47:53 +00:00 committed by GitHub
parent 80367b827a
commit 597316125f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/app/components/user-card-contents.hbs
View File

@ -241,8 +241,8 @@
this.user.featured_topic.slug this.user.featured_topic.slug
this.user.featured_topic.id this.user.featured_topic.id
}} }}
>{{html-safe >{{replace-emoji
(replace-emoji this.user.featured_topic.fancy_title) (html-safe this.user.featured_topic.fancy_title)
}}</LinkTo> }}</LinkTo>
</div> </div>
</div> </div>