Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

PERF: poor SQL performances when counting notifications

This commit is contained in:
Régis Hanol 2015-06-22 14:32:45 +02:00
parent ef0f1b2dbd
commit 5a77f62181
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/notification.rb
View File

@ -8,10 +8,8 @@ class Notification < ActiveRecord::Base
validates_presence_of :notification_type
scope :unread, lambda { where(read: false) }
scope :recent, lambda {|n=nil| n ||= 10; order('notifications.created_at desc').limit(n) }
scope :visible , lambda { where('notifications.topic_id IS NULL OR notifications.topic_id IN (
SELECT id FROM topics
WHERE deleted_at IS NULL)') }
scope :recent, lambda { |n=nil| n ||= 10; order('notifications.created_at desc').limit(n) }
scope :visible , lambda { joins('LEFT JOIN topics ON notifications.topic_id = topics.id AND topics.deleted_at IS NULL') }
after_save :refresh_notification_count
after_destroy :refresh_notification_count