From 5bdf476de7a0368aeb823abaa28c77c3cb7e611f Mon Sep 17 00:00:00 2001 From: pmusaraj Date: Thu, 13 Sep 2018 08:40:57 -0400 Subject: [PATCH] raise error early in drafts controller --- app/controllers/drafts_controller.rb | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/app/controllers/drafts_controller.rb b/app/controllers/drafts_controller.rb index 00afdf2f7cb..43def371853 100644 --- a/app/controllers/drafts_controller.rb +++ b/app/controllers/drafts_controller.rb @@ -10,27 +10,27 @@ class DraftsController < ApplicationController user = fetch_user_from_params + unless user == current_user + raise Discourse::InvalidAccess + end + opts = { user: user, offset: params[:offset], limit: params[:limit] } - if user == current_user - stream = Draft.stream(opts) - stream.each do |d| - parsed_data = JSON.parse(d.data) - if parsed_data - if parsed_data['reply'] - d.raw = parsed_data['reply'] - end - if parsed_data['categoryId'].present? && !d.category_id.present? - d.category_id = parsed_data['categoryId'] - end + stream = Draft.stream(opts) + stream.each do |d| + parsed_data = JSON.parse(d.data) + if parsed_data + if parsed_data['reply'] + d.raw = parsed_data['reply'] + end + if parsed_data['categoryId'].present? && !d.category_id.present? + d.category_id = parsed_data['categoryId'] end end - else - raise Discourse::InvalidAccess end render json: {