DEV: improve UserSummarySerializer spec

spec/serializers/user_summary_serializer_spec.rb

@@ -4,7 +4,8 @@ describe UserSummarySerializer do
   it "returns expected data" do
     UserActionCreator.enable
     user = Fabricate(:user)
-    liked_post = create_post
+    liked_user = Fabricate(:user, name: "John Doe", username: "john_doe")
+    liked_post = create_post(user: liked_user)
     PostAction.act(user, liked_post, PostActionType.types[:like])
 
     guardian = Guardian.new(user)
@@ -17,8 +18,13 @@ describe UserSummarySerializer do
     expect(json[:posts_read_count]).to be_present
     expect(json[:topic_count]).to be_present
     expect(json[:time_read]).to be_present
-    expect(json[:most_liked_users][0][:count]).to be_present
-    expect(json[:most_liked_users][0][:username]).to be_present
-    expect(json[:most_liked_users][0][:avatar_template]).to be_present
+    expect(json[:most_liked_users][0][:count]).to eq(1)
+    expect(json[:most_liked_users][0][:name]).to eq("John Doe")
+    expect(json[:most_liked_users][0][:username]).to eq("john_doe")
+    expect(json[:most_liked_users][0][:avatar_template]).to eq(liked_user.avatar_template)
+
+    # do not include full name if disabled
+    SiteSetting.enable_names = false
+    expect(serializer.as_json[:most_liked_users][0][:name]).to eq(nil)
   end
 end