Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: make tests less fragile

This commit is contained in:
Sam 2018-06-14 18:31:07 +10:00
parent 87fabdc2f3
commit 5f86434bf1
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
spec/requests/search_controller_spec.rb
View File

@ -6,6 +6,12 @@ describe SearchController do
SearchIndexer.enable SearchIndexer.enable
end end
before do
# TODO be a bit more strategic here instead of junking
# all of redis
$redis.flushall
end
after do after do
$redis.flushall $redis.flushall
end end
@ -175,7 +181,7 @@ describe SearchController do
sign_in(Fabricate(:user)) sign_in(Fabricate(:user))
_, search_log_id = SearchLog.log( _, search_log_id = SearchLog.log(
term: 'kitty', term: SecureRandom.hex,
search_type: :header, search_type: :header,
user_id: -10, user_id: -10,
ip_address: '127.0.0.1' ip_address: '127.0.0.1'
@ -195,7 +201,7 @@ describe SearchController do
user = sign_in(Fabricate(:user)) user = sign_in(Fabricate(:user))
_, search_log_id = SearchLog.log( _, search_log_id = SearchLog.log(
term: 'foobar', term: SecureRandom.hex,
search_type: :header, search_type: :header,
user_id: user.id, user_id: user.id,
ip_address: '127.0.0.1' ip_address: '127.0.0.1'
@ -217,7 +223,7 @@ describe SearchController do
ip_address = request.remote_ip ip_address = request.remote_ip
_, search_log_id = SearchLog.log( _, search_log_id = SearchLog.log(
term: 'kitty', term: SecureRandom.hex,
search_type: :header, search_type: :header,
ip_address: ip_address ip_address: ip_address
) )
@ -235,7 +241,7 @@ describe SearchController do
it "doesn't record the click for a different IP" do it "doesn't record the click for a different IP" do
_, search_log_id = SearchLog.log( _, search_log_id = SearchLog.log(
term: 'kitty', term: SecureRandom.hex,
search_type: :header, search_type: :header,
ip_address: '192.168.0.19' ip_address: '192.168.0.19'
) )
@ -255,7 +261,7 @@ describe SearchController do
ip_address = request.remote_ip ip_address = request.remote_ip
_, search_log_id = SearchLog.log( _, search_log_id = SearchLog.log(
term: 'dev', term: SecureRandom.hex,
search_type: :header, search_type: :header,
ip_address: ip_address ip_address: ip_address
) )
@ -277,7 +283,7 @@ describe SearchController do
tag = Fabricate(:tag, name: 'test') tag = Fabricate(:tag, name: 'test')
_, search_log_id = SearchLog.log( _, search_log_id = SearchLog.log(
term: 'test', term: SecureRandom.hex,
search_type: :header, search_type: :header,
ip_address: ip_address ip_address: ip_address
) )