Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DEV: Cleanup `for` attributes in category edit screens (#15284)

This commit is contained in:
Penar Musaraj 2021-12-15 12:37:11 -05:00 committed by GitHub
parent 0335c9d77f
commit 6120dde65c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/assets/javascripts/discourse/app/templates/components/edit-category-settings.hbs
View File

@ -27,7 +27,7 @@
</section> </section>
<section class="field search-priority"> <section class="field search-priority">
<label for="category-search-priority"> <label>
{{i18n "category.search_priority.label"}} {{i18n "category.search_priority.label"}}
</label> </label>
<div class="controls"> <div class="controls">
@ -90,9 +90,7 @@
<h3>{{i18n "category.settings_sections.moderation"}}</h3> <h3>{{i18n "category.settings_sections.moderation"}}</h3>
{{#if siteSettings.enable_category_group_moderation}} {{#if siteSettings.enable_category_group_moderation}}
<section class="field reviewable-by-group"> <section class="field reviewable-by-group">
<label for="reviewable-by-group"> <label>{{i18n "category.reviewable_by_group"}}</label>
{{i18n "category.reviewable_by_group"}}
</label>
{{group-selector {{group-selector
groupFinder=groupFinder groupFinder=groupFinder
single="true" single="true"
@ -171,7 +169,7 @@
<h3>{{i18n "category.settings_sections.appearance"}}</h3> <h3>{{i18n "category.settings_sections.appearance"}}</h3>
<section class="field default-view-field"> <section class="field default-view-field">
<label for="category-default-view"> <label>
{{i18n "category.default_view"}} {{i18n "category.default_view"}}
</label> </label>
<div class="controls"> <div class="controls">
@ -188,7 +186,7 @@
</section> </section>
<section class="field default-top-period-field"> <section class="field default-top-period-field">
<label for="category-default-period"> <label>
{{i18n "category.default_top_period"}} {{i18n "category.default_top_period"}}
</label> </label>
<div class="controls"> <div class="controls">
@ -205,7 +203,7 @@
</section> </section>
<section class="field sort-order"> <section class="field sort-order">
<label for="category-sort-order"> <label>
{{i18n "category.sort_order"}} {{i18n "category.sort_order"}}
</label> </label>
<div class="controls"> <div class="controls">
@ -234,7 +232,7 @@
</section> </section>
<section class="field default-filter"> <section class="field default-filter">
<label for="category-default-filter"> <label>
{{i18n "category.default_list_filter"}} {{i18n "category.default_list_filter"}}
</label> </label>
<div class="controls"> <div class="controls">
@ -258,7 +256,7 @@
{{#if showSubcategoryListStyle}} {{#if showSubcategoryListStyle}}
<section class="field subcategory-list-style-field"> <section class="field subcategory-list-style-field">
<label for="subcategory-list-style"> <label>
{{i18n "category.subcategory_list_style"}} {{i18n "category.subcategory_list_style"}}
</label> </label>
{{combo-box {{combo-box
@ -274,9 +272,7 @@
{{/if}} {{/if}}
<section class="field category-read-only-banner"> <section class="field category-read-only-banner">
<label for="category-read-only-banner"> <label for="read-only-message">{{i18n "category.read_only_banner"}}</label>
{{i18n "category.read_only_banner"}}
</label>
{{text-field {{text-field
valueProperty="value" valueProperty="value"
id="read-only-message" id="read-only-message"

6
app/assets/javascripts/discourse/app/templates/components/edit-category-tags.hbs
View File

@ -1,5 +1,5 @@
<section class="field allowed-tags"> <section class="field allowed-tags">
<label for="category-allowed-tags">{{i18n "category.tags_allowed_tags"}}</label> <label>{{i18n "category.tags_allowed_tags"}}</label>
{{tag-chooser {{tag-chooser
id="category-allowed-tags" id="category-allowed-tags"
tags=category.allowed_tags tags=category.allowed_tags
@ -14,7 +14,7 @@
</section> </section>
<section class="field allowed-tag-groups"> <section class="field allowed-tag-groups">
<label for="category-allowed-tag-groups">{{i18n "category.tags_allowed_tag_groups"}}</label> <label>{{i18n "category.tags_allowed_tag_groups"}}</label>
{{tag-group-chooser {{tag-group-chooser
id="category-allowed-tag-groups" id="category-allowed-tag-groups"
tagGroups=category.allowed_tag_groups tagGroups=category.allowed_tag_groups
@ -39,7 +39,7 @@
<section class="field with-items"> <section class="field with-items">
<section class="field-item min-tags-from-required-group"> <section class="field-item min-tags-from-required-group">
<label>{{i18n "category.min_tags_from_required_group_label"}}</label> <label for="category-min-tags-from-group">{{i18n "category.min_tags_from_required_group_label"}}</label>
{{text-field value=category.min_tags_from_required_group id="category-min-tags-from-group" type="number" min="1"}} {{text-field value=category.min_tags_from_required_group id="category-min-tags-from-group" type="number" min="1"}}
</section> </section>
<section class="field-item required-tag-group"> <section class="field-item required-tag-group">

10
app/assets/javascripts/discourse/app/templates/components/relative-time-picker.hbs
View File

@ -1,5 +1,13 @@
<div class="relative-time-picker"> <div class="relative-time-picker">
{{input class="relative-time-duration" min=durationMin step=durationStep type="number" value=duration onChange=(action "onChangeDuration")}} {{input
class="relative-time-duration"
min=durationMin
step=durationStep
type="number"
value=duration
onChange=(action "onChangeDuration")
id=id
}}
{{combo-box {{combo-box
content=intervals content=intervals
value=selectedInterval value=selectedInterval